Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1178)

Unified Diff: src/wasm/wasm-module.cc

Issue 2474333003: [wasm] Exported memory should set maximum property when maximum is defined. (Closed)
Patch Set: Format Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/wasm/import-memory.js » ('j') | test/mjsunit/wasm/import-memory.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/wasm/wasm-module.cc
diff --git a/src/wasm/wasm-module.cc b/src/wasm/wasm-module.cc
index 64f5663aeb55c0a1fa74914ab16a65f139943169..e9ad300fb303300e538ffadc7ee92a8bd2dcc37c 100644
--- a/src/wasm/wasm-module.cc
+++ b/src/wasm/wasm-module.cc
@@ -1676,8 +1676,9 @@ class WasmInstanceBuilder {
JSArrayBuffer::cast(
instance->GetInternalField(kWasmMemArrayBuffer)),
isolate_);
- memory_object =
- WasmJs::CreateWasmMemoryObject(isolate_, buffer, false, 0);
+ memory_object = WasmJs::CreateWasmMemoryObject(
+ isolate_, buffer, (module_->max_mem_pages != 0),
+ module_->max_mem_pages);
instance->SetInternalField(kWasmMemObject, *memory_object);
}
« no previous file with comments | « no previous file | test/mjsunit/wasm/import-memory.js » ('j') | test/mjsunit/wasm/import-memory.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698