[wasm] Exported memory should set maximum property when maximum is defined.

[wasm] Linear/Exported memory maximum property should be set when maximum is defined.
 - When module bytes have a memory maximum defined, compiled module object should set maximum memory
 - Exported memory objects should set maximum value on the memory objects
 - Update tests to use declared maximum values.

R=ahaas@chromium.org

Committed: https://crrev.com/625767df910ef6787c7524c456782d9d01617bb9
Cr-Commit-Position: refs/heads/master@{#40820}

[gdeepti, 2016-11-04 05:49:14]

The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 05:49:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gdeepti, 2016-11-04 06:06:54]

The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 06:06:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 06:35:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 06:35:11]

Dry run: This issue passed the CQ dry run.

[ahaas, 2016-11-04 09:12:17]

Thanks for doing this so fast! lgtm

https://codereview.chromium.org/2474333003/diff/10019/test/mjsunit/wasm/impor...
File test/mjsunit/wasm/import-memory.js (right):

https://codereview.chromium.org/2474333003/diff/10019/test/mjsunit/wasm/impor...
test/mjsunit/wasm/import-memory.js:208: builder.addMemory(1, 10, true);
nit: define constants for these values?

https://codereview.chromium.org/2474333003/diff/10019/test/mjsunit/wasm/impor...
test/mjsunit/wasm/import-memory.js:225: var current_mem_size = 1;
nit: use the constants you defined above here?

[gdeepti, 2016-11-08 02:34:13]

The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 02:34:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 02:49:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 02:49:11]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[gdeepti, 2016-11-08 05:52:51]

The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 05:52:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gdeepti, 2016-11-08 06:06:01]

The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 06:06:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gdeepti, 2016-11-08 06:10:22]

The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 06:10:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 06:23:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 06:23:18]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_asan_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_trig...)

[gdeepti, 2016-11-08 07:19:40]

Description was changed from

==========
[wasm] Exported memory should set maximum property when maximum is defined.

R=ahaas@chromium.org
==========

to

==========
[wasm] Linear/Exported memory maximum property should be set when maximum is
defined.

R=ahaas@chromium.org
==========

[gdeepti, 2016-11-08 07:40:11]

The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 07:40:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gdeepti, 2016-11-08 08:01:01]

https://codereview.chromium.org/2474333003/diff/10019/test/mjsunit/wasm/impor...
File test/mjsunit/wasm/import-memory.js (right):

https://codereview.chromium.org/2474333003/diff/10019/test/mjsunit/wasm/impor...
test/mjsunit/wasm/import-memory.js:208: builder.addMemory(1, 10, true);
On 2016/11/04 09:12:17, ahaas wrote:
> nit: define constants for these values?

Not adding constants for these values as these are initial/maximum function
parameters to addMemory and are consistent with the rest of the file.

https://codereview.chromium.org/2474333003/diff/10019/test/mjsunit/wasm/impor...
test/mjsunit/wasm/import-memory.js:225: var current_mem_size = 1;
On 2016/11/04 09:12:17, ahaas wrote:
> nit: use the constants you defined above here?

Removed left over constant.

[commit-bot: I haz the power, 2016-11-08 08:04:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 08:04:03]

Dry run: This issue passed the CQ dry run.

[ahaas, 2016-11-08 08:07:07]

On 2016/11/08 at 08:01:01, gdeepti wrote:
>
https://codereview.chromium.org/2474333003/diff/10019/test/mjsunit/wasm/impor...
> File test/mjsunit/wasm/import-memory.js (right):
> 
>
https://codereview.chromium.org/2474333003/diff/10019/test/mjsunit/wasm/impor...
> test/mjsunit/wasm/import-memory.js:208: builder.addMemory(1, 10, true);
> On 2016/11/04 09:12:17, ahaas wrote:
> > nit: define constants for these values?
> 
> Not adding constants for these values as these are initial/maximum function
parameters to addMemory and are consistent with the rest of the file.
> 
I'm not sure if I misunderstand you, or if you misunderstand me. What I mean is
that I think the code would be more readable if it said 
for (var i = initial_size; i < maximum_size; i++) instead of for (var i = 1; i <
10; i++). 


>
https://codereview.chromium.org/2474333003/diff/10019/test/mjsunit/wasm/impor...
> test/mjsunit/wasm/import-memory.js:225: var current_mem_size = 1;
> On 2016/11/04 09:12:17, ahaas wrote:
> > nit: use the constants you defined above here?
> 
> Removed left over constant.

[ahaas, 2016-11-08 08:11:08]

https://codereview.chromium.org/2474333003/diff/130001/test/mjsunit/wasm/grow...
File test/mjsunit/wasm/grow-memory.js (right):

https://codereview.chromium.org/2474333003/diff/130001/test/mjsunit/wasm/grow...
test/mjsunit/wasm/grow-memory.js:46: builder.addMemory(1, kV8MaxPages, false);
Can you add a test where you set max_size to 65535?

[ahaas, 2016-11-08 08:45:35]

On 2016/11/08 at 08:11:08, ahaas wrote:
>
https://codereview.chromium.org/2474333003/diff/130001/test/mjsunit/wasm/grow...
> File test/mjsunit/wasm/grow-memory.js (right):
> 
>
https://codereview.chromium.org/2474333003/diff/130001/test/mjsunit/wasm/grow...
> test/mjsunit/wasm/grow-memory.js:46: builder.addMemory(1, kV8MaxPages, false);
> Can you add a test where you set max_size to 65535?

still lgtm

[gdeepti, 2016-11-08 08:46:51]

The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 08:47:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gdeepti, 2016-11-08 08:48:31]

On 2016/11/08 08:07:07, ahaas wrote:
> On 2016/11/08 at 08:01:01, gdeepti wrote:
> >
>
https://codereview.chromium.org/2474333003/diff/10019/test/mjsunit/wasm/impor...
> > File test/mjsunit/wasm/import-memory.js (right):
> > 
> >
>
https://codereview.chromium.org/2474333003/diff/10019/test/mjsunit/wasm/impor...
> > test/mjsunit/wasm/import-memory.js:208: builder.addMemory(1, 10, true);
> > On 2016/11/04 09:12:17, ahaas wrote:
> > > nit: define constants for these values?
> > 
> > Not adding constants for these values as these are initial/maximum function
> parameters to addMemory and are consistent with the rest of the file.
> > 
> I'm not sure if I misunderstand you, or if you misunderstand me. What I mean
is
> that I think the code would be more readable if it said 
> for (var i = initial_size; i < maximum_size; i++) instead of for (var i = 1; i
<
> 10; i++). 
Done
> 
> >
>
https://codereview.chromium.org/2474333003/diff/10019/test/mjsunit/wasm/impor...
> > test/mjsunit/wasm/import-memory.js:225: var current_mem_size = 1;
> > On 2016/11/04 09:12:17, ahaas wrote:
> > > nit: use the constants you defined above here?
> > 
> > Removed left over constant.

[gdeepti, 2016-11-08 08:50:18]

https://codereview.chromium.org/2474333003/diff/130001/test/mjsunit/wasm/grow...
File test/mjsunit/wasm/grow-memory.js (right):

https://codereview.chromium.org/2474333003/diff/130001/test/mjsunit/wasm/grow...
test/mjsunit/wasm/grow-memory.js:46: builder.addMemory(1, kV8MaxPages, false);
On 2016/11/08 08:11:08, ahaas wrote:
> Can you add a test where you set max_size to 65535? 

Done.

[gdeepti, 2016-11-08 08:59:52]

Description was changed from

==========
[wasm] Linear/Exported memory maximum property should be set when maximum is
defined.

R=ahaas@chromium.org
==========

to

==========
[wasm] Linear/Exported memory maximum property should be set when maximum is
defined.
 - When module bytes have a memory maximum defined, compiled module object
should set maximum memory
 - Exported memory objects should set maximum value on the memory objects
 - Update tests to use declared maximum values.
 
R=ahaas@chromium.org
==========

[commit-bot: I haz the power, 2016-11-08 09:19:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 09:19:19]

Dry run: Try jobs failed on following builders:
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/12081)
  v8_mac_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/bui...)

[gdeepti, 2016-11-08 09:30:45]

The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 09:30:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gdeepti, 2016-11-08 09:32:17]

The CQ bit was unchecked by gdeepti@chromium.org

[gdeepti, 2016-11-08 09:32:32]

The CQ bit was checked by gdeepti@chromium.org

[gdeepti, 2016-11-08 09:32:32]

The patchset sent to the CQ was uploaded after l-g-t-m from ahaas@chromium.org
Link to the patchset: https://codereview.chromium.org/2474333003/#ps190001
(title: "Remove large allocation, fails on macw")

[commit-bot: I haz the power, 2016-11-08 09:32:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 09:55:11]

Description was changed from

==========
[wasm] Linear/Exported memory maximum property should be set when maximum is
defined.
 - When module bytes have a memory maximum defined, compiled module object
should set maximum memory
 - Exported memory objects should set maximum value on the memory objects
 - Update tests to use declared maximum values.
 
R=ahaas@chromium.org
==========

to

==========
[wasm] Linear/Exported memory maximum property should be set when maximum is
defined.
 - When module bytes have a memory maximum defined, compiled module object
should set maximum memory
 - Exported memory objects should set maximum value on the memory objects
 - Update tests to use declared maximum values.
 
R=ahaas@chromium.org
==========

[commit-bot: I haz the power, 2016-11-08 09:55:12]

Committed patchset #11 (id:190001)

[commit-bot: I haz the power, 2016-11-17 22:25:31]

Description was changed from

==========
[wasm] Linear/Exported memory maximum property should be set when maximum is
defined.
 - When module bytes have a memory maximum defined, compiled module object
should set maximum memory
 - Exported memory objects should set maximum value on the memory objects
 - Update tests to use declared maximum values.
 
R=ahaas@chromium.org
==========

to

==========
[wasm] Linear/Exported memory maximum property should be set when maximum is
defined.
 - When module bytes have a memory maximum defined, compiled module object
should set maximum memory
 - Exported memory objects should set maximum value on the memory objects
 - Update tests to use declared maximum values.

R=ahaas@chromium.org

Committed: https://crrev.com/625767df910ef6787c7524c456782d9d01617bb9
Cr-Commit-Position: refs/heads/master@{#40820}
==========

[commit-bot: I haz the power, 2016-11-17 22:25:32]

Patchset 11 (id:??) landed as
https://crrev.com/625767df910ef6787c7524c456782d9d01617bb9
Cr-Commit-Position: refs/heads/master@{#40820}