chrome/browser/sync/glue/non_ui_data_type_controller.h - Issue 247433004: sync: remove CreateSharedChangeProcessor from ProfileSyncComponentsFactory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/non_ui_data_type_controller.h

Issue 247433004: sync: remove CreateSharedChangeProcessor from ProfileSyncComponentsFactory (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: remove SCPFactory Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/glue/autofill_profile_data_type_controller.cc ('k') | chrome/browser/sync/glue/non_ui_data_type_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/glue/non_ui_data_type_controller.h

diff --git a/chrome/browser/sync/glue/non_ui_data_type_controller.h b/chrome/browser/sync/glue/non_ui_data_type_controller.h

index 696aee246d6b3c4edc0e908923ed391034da2b1a..f7c8d68d4429af68d3aa769af114a25a43eddc27 100644

--- a/chrome/browser/sync/glue/non_ui_data_type_controller.h

+++ b/chrome/browser/sync/glue/non_ui_data_type_controller.h

@@ -99,6 +99,10 @@ class NonUIDataTypeController : public DataTypeController {

// Record causes of start failure.

virtual void RecordStartFailure(StartResult result);

+ // To allow unit tests to control thread interaction during non-ui startup

+ // and shutdown, use a factory method to create the SharedChangeProcessor.

+ virtual SharedChangeProcessor* CreateSharedChangeProcessor();

Profile* profile() const { return profile_; }

private: