content/browser/renderer_host/input/touch_emulator_unittest.cc - Issue 247433003: Mark touchcancel events as uncancelable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/input/touch_emulator_unittest.cc

Issue 247433003: Mark touchcancel events as uncancelable (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: avi CR feedback Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/input/touch_emulator_unittest.cc

diff --git a/content/browser/renderer_host/input/touch_emulator_unittest.cc b/content/browser/renderer_host/input/touch_emulator_unittest.cc

index 7593fb704b259391e775865450e278c29650fb74..88ba25150009cb8200f160520702d71923f6f058 100644

--- a/content/browser/renderer_host/input/touch_emulator_unittest.cc

+++ b/content/browser/renderer_host/input/touch_emulator_unittest.cc

@@ -76,6 +76,8 @@ class TouchEmulatorTest : public testing::Test,

EXPECT_EQ(1U, event.touchesLength);

EXPECT_EQ(last_mouse_x_, event.touches[0].position.x);

EXPECT_EQ(last_mouse_y_, event.touches[0].position.y);

+ int expectedCancelable = event.type != WebInputEvent::TouchCancel;

+ EXPECT_EQ(expectedCancelable, event.cancelable);

emulator()->HandleTouchEventAck(INPUT_EVENT_ACK_STATE_NO_CONSUMER_EXISTS);

}