Mark touchcancel events as uncancelable

content/browser/renderer_host/input/motion_event_web.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/input/motion_event_web.h"
 
 #include "base/logging.h"
+#include "content/common/input/web_touch_event_traits.h"
 
 using blink::WebInputEvent;
 using blink::WebTouchEvent;
 using blink::WebTouchPoint;
 
 namespace content {
 namespace {
 
-bool AllTouchPointsHaveState(const WebTouchEvent& event,
-                             WebTouchPoint::State state) {
-  for (size_t i = 0; i < event.touchesLength; ++i) {
-    if (event.touches[i].state != state)
-      return false;
-  }
-  return true;
-}
-
 ui::MotionEvent::Action GetActionFrom(const WebTouchEvent& event) {
-  // TODO(jdduke): Use WebTouchEventTraits.
   DCHECK(event.touchesLength);
   switch (event.type) {
     case WebInputEvent::TouchStart:

[jdduke (slow), 2014/04/23 21:55:47]

Is this "git cl format" ed?

-      if (AllTouchPointsHaveState(event, WebTouchPoint::StatePressed))
+      if (WebTouchEventTraits::AllTouchPointsHaveState(event,
+          WebTouchPoint::StatePressed))
         return ui::MotionEvent::ACTION_DOWN;
       else
         return ui::MotionEvent::ACTION_POINTER_DOWN;
     case WebInputEvent::TouchEnd:
-      if (AllTouchPointsHaveState(event, WebTouchPoint::StateReleased))
+      if (WebTouchEventTraits::AllTouchPointsHaveState(event,
+          WebTouchPoint::StateReleased))
         return ui::MotionEvent::ACTION_UP;
       else
         return ui::MotionEvent::ACTION_POINTER_UP;
     case WebInputEvent::TouchCancel:
-      DCHECK(AllTouchPointsHaveState(event, WebTouchPoint::StateCancelled));
+      DCHECK(WebTouchEventTraits::AllTouchPointsHaveState(event,
+          WebTouchPoint::StateCancelled));
       return ui::MotionEvent::ACTION_CANCEL;
     case WebInputEvent::TouchMove:
       return ui::MotionEvent::ACTION_MOVE;
     default:
       break;
   };
   NOTREACHED()
       << "Unable to derive a valid MotionEvent::Action from the WebTouchEvent.";
   return ui::MotionEvent::ACTION_CANCEL;
 }
@@ skipping 87 matching lines @@
   NOTIMPLEMENTED();
   return 0.f;
 }
 
 scoped_ptr<ui::MotionEvent> MotionEventWeb::Clone() const {
   return scoped_ptr<MotionEvent>(new MotionEventWeb(event_));
 }
 
 scoped_ptr<ui::MotionEvent> MotionEventWeb::Cancel() const {
   WebTouchEvent cancel_event(event_);
-
-  cancel_event.type = WebInputEvent::TouchCancel;
-  for (size_t i = 0; i < cancel_event.touchesLength; ++i)
-    cancel_event.touches[i].state = WebTouchPoint::StateCancelled;
-
+  WebTouchEventTraits::ResetType(&cancel_event,
+      blink::WebInputEvent::TouchCancel,
+      // FIXME: Shouldn't we use a fresh timestamp?

[jdduke (slow), 2014/04/23 21:55:47]

Hmm... yeah, probably.

[Rick Byers, 2014/04/23 23:15:35]

This is simple enough that I can just fix it here if you like (but then I should
add a test for it - perhaps better in a follow-up CL).

+      event_.timeStampSeconds,
+      WebTouchEventTraits::RESET_TOUCHES_STATE);
   return scoped_ptr<MotionEvent>(new MotionEventWeb(cancel_event));
 }
 
 }  // namespace content