Mark touchcancel events as uncancelable

content/browser/frame_host/render_widget_host_view_guest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/message_loop/message_loop.h"
 #include "content/browser/browser_plugin/browser_plugin_guest.h"
 #include "content/browser/frame_host/render_widget_host_view_guest.h"
 #include "content/browser/renderer_host/render_view_host_impl.h"
 #include "content/common/browser_plugin/browser_plugin_messages.h"
 #include "content/common/frame_messages.h"
 #include "content/common/gpu/gpu_messages.h"
 #include "content/common/host_shared_bitmap_manager.h"
+#include "content/common/input/web_touch_event_traits.h"
 #include "content/common/view_messages.h"
 #include "content/common/webplugin_geometry.h"
 #include "content/public/common/content_switches.h"
 #include "skia/ext/platform_canvas.h"
 #include "third_party/WebKit/public/platform/WebScreenInfo.h"
 
 #if defined(OS_MACOSX)
 #import "content/browser/renderer_host/render_widget_host_view_mac_dictionary_helper.h"
 #endif
 
@@ skipping 498 matching lines @@
     ui::GestureEvent* event) {
   ForwardGestureEventToRenderer(event);
 }
 
 void RenderWidgetHostViewGuest::DispatchCancelTouchEvent(
     ui::TouchEvent* event) {
   if (!host_)
     return;
 
   blink::WebTouchEvent cancel_event;
-  cancel_event.type = blink::WebInputEvent::TouchCancel;
-  cancel_event.timeStampSeconds = event->time_stamp().InSecondsF();
+  // FIXME: This event has no touches in it.  Don't we need to know what
+  // touches are currently active in order to cancel them all properly?
+  WebTouchEventTraits::ResetType(&cancel_event,
+      blink::WebInputEvent::TouchCancel,
+      event->time_stamp().InSecondsF(),
+      WebTouchEventTraits::IGNORE_TOUCHES_STATE);
   host_->ForwardTouchEventWithLatencyInfo(cancel_event, *event->latency());

[jdduke (slow), 2014/04/23 21:55:47]

Hmm, yeah, at the least this should be touchesLength = 1...

[Rick Byers, 2014/04/23 23:15:35]

But then there's the question of what the co-ordinates should be for the touch,
etc.  I think I'd prefer to avoid changing this now in this CL, wdyt?  I assume
this just affects webview / out-of-process-iframes?

[jdduke (slow), 2014/04/23 23:29:49]

Sounds good,  yeah, I'm not super familiar with this class.

 }
 
 bool RenderWidgetHostViewGuest::ForwardGestureEventToRenderer(
     ui::GestureEvent* gesture) {
 #if defined(USE_AURA)
   if (!host_)
     return false;
 
   if ((gesture->type() == ui::ET_GESTURE_PINCH_BEGIN ||
       gesture->type() == ui::ET_GESTURE_PINCH_UPDATE ||
@@ skipping 33 matching lines @@
       ++g_it) {
     ForwardGestureEventToRenderer(*g_it);
   }
 }
 
 SkBitmap::Config RenderWidgetHostViewGuest::PreferredReadbackFormat() {
   return SkBitmap::kARGB_8888_Config;
 }
 
 }  // namespace content