third_party/WebKit/Source/wtf/Threading.h - Issue 2474303004: Remove mutex locks in SchemeRegistry

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/wtf/Threading.h

Issue 2474303004: Remove mutex locks in SchemeRegistry (Closed)

Patch Set: tkent review Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/platform/weborigin/SchemeRegistry.cpp ('K') | « third_party/WebKit/Source/platform/weborigin/SchemeRegistry.cpp ('k') | third_party/WebKit/Source/wtf/ThreadingPthreads.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2007, 2008, 2010 Apple Inc. All rights reserved.	2 * Copyright (C) 2007, 2008, 2010 Apple Inc. All rights reserved.

3 * Copyright (C) 2007 Justin Haygood (jhaygood@reaktix.com)	3 * Copyright (C) 2007 Justin Haygood (jhaygood@reaktix.com)

4 *	4 *

5 * Redistribution and use in source and binary forms, with or without	5 * Redistribution and use in source and binary forms, with or without

6 * modification, are permitted provided that the following conditions	6 * modification, are permitted provided that the following conditions

7 * are met:	7 * are met:

8 *	8 *

9 * 1. Redistributions of source code must retain the above copyright	9 * 1. Redistributions of source code must retain the above copyright

10 * notice, this list of conditions and the following disclaimer.	10 * notice, this list of conditions and the following disclaimer.

(...skipping 47 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
58 typedef uint32_t ThreadIdentifier;	58 typedef uint32_t ThreadIdentifier;

59 #else	59 #else

60 typedef intptr_t ThreadIdentifier;	60 typedef intptr_t ThreadIdentifier;

61 #endif	61 #endif

62	62

63 WTF_EXPORT ThreadIdentifier currentThread();	63 WTF_EXPORT ThreadIdentifier currentThread();

64	64

65 WTF_EXPORT void lockAtomicallyInitializedStaticMutex();	65 WTF_EXPORT void lockAtomicallyInitializedStaticMutex();

66 WTF_EXPORT void unlockAtomicallyInitializedStaticMutex();	66 WTF_EXPORT void unlockAtomicallyInitializedStaticMutex();

67	67

68 #if ENABLE(ASSERT)	68 // Empty implementations of these functions are defined when !ENABLE(ASSERT) so

	69 // they can be used within DCHECKs.
	kinuko 2016/11/09 03:56:37 The empty impls don't really make sense, I might j The empty impls don't really make sense, I might just add a comment to note that they are not defined in !ENABLE(ASSERT) cases and they can only be used inside ASSERT or DCHECKs. (I defer the decisions to Kent-san) Charlie Harrison 2016/11/09 15:31:39 I agree with you. Changed to be a comment. Show quoted text On 2016/11/09 03:56:37, kinuko wrote: > The empty impls don't really make sense, I might just add a comment to note that > they are not defined in !ENABLE(ASSERT) cases and they can only be used inside > ASSERT or DCHECKs. > > (I defer the decisions to Kent-san) I agree with you. Changed to be a comment.
69 WTF_EXPORT bool isAtomicallyInitializedStaticMutexLockHeld();	70 WTF_EXPORT bool isAtomicallyInitializedStaticMutexLockHeld();

70 WTF_EXPORT bool isBeforeThreadCreated();	71 WTF_EXPORT bool isBeforeThreadCreated();

71 WTF_EXPORT void willCreateThread();	72 WTF_EXPORT void willCreateThread();

72 #endif

73	73

74 } // namespace WTF	74 } // namespace WTF

75	75

76 using WTF::ThreadIdentifier;	76 using WTF::ThreadIdentifier;

77 using WTF::currentThread;	77 using WTF::currentThread;

78	78

79 #endif // Threading_h	79 #endif // Threading_h

OLD	NEW