Clean up fpdf_page_parsers

Clean up fpdf_page_parsers

- The code in fpdf_page_parser is only called by CPDF_StreamContentParser, so moved there.
- Split fpdf_page_parser_old into its two classes
- Renamed the corresponding unittests accordingly.
- Moved PDF_ReplaceAbbr to namespace
- Fixed few nits
- Added TODO because CPDF_StreamParser has a lot of code similar to CPDF_SyntaxParser

Committed: https://pdfium.googlesource.com/pdfium/+/014b012278b7438ef8d4b66730b8598c7eb4623a

[npm, 2016-11-04 17:34:06]

Description was changed from

==========
Clean up fpdf_page_parsers
==========

to

==========
Clean up fpdf_page_parsers

- The code in fpdf_page_parser is only called by CPDF_StreamContentParser, so
moved there.
- Split fpdf_page_parser_old into its two classes
- Renamed the corresponding unittests accordingly.
==========

[npm, 2016-11-04 18:46:13]

Description was changed from

==========
Clean up fpdf_page_parsers

- The code in fpdf_page_parser is only called by CPDF_StreamContentParser, so
moved there.
- Split fpdf_page_parser_old into its two classes
- Renamed the corresponding unittests accordingly.
==========

to

==========
Clean up fpdf_page_parsers

- The code in fpdf_page_parser is only called by CPDF_StreamContentParser, so
moved there.
- Split fpdf_page_parser_old into its two classes
- Renamed the corresponding unittests accordingly.
- Moved PDF_ReplaceAbbr to namespace
- Fixed few nits
- Added TODO because CPDF_StreamParser has a lot of code similar to
CPDF_SyntaxParser
==========

[npm, 2016-11-04 18:46:13]

npm@chromium.org changed reviewers:
+ dsinclair@chromium.org, thestig@chromium.org, weili@chromium.org

[npm, 2016-11-04 18:46:23]

The CQ bit was checked by npm@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 18:46:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[npm, 2016-11-04 18:52:07]

PTAL

[commit-bot: I haz the power, 2016-11-04 19:01:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 19:01:05]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-11-07 14:19:55]

lgtm w/ nit.

https://codereview.chromium.org/2474303003/diff/20001/core/fpdfapi/page/cpdf_...
File core/fpdfapi/page/cpdf_streamcontentparser.cpp (right):

https://codereview.chromium.org/2474303003/diff/20001/core/fpdfapi/page/cpdf_...
core/fpdfapi/page/cpdf_streamcontentparser.cpp:137: const PDF_AbbrPair
PDF_InlineKeyAbbr[] = {
nit: Since these are all in the anonymous namespace, can we drop the PDF_
prefixes?

[npm, 2016-11-07 16:18:39]

https://codereview.chromium.org/2474303003/diff/20001/core/fpdfapi/page/cpdf_...
File core/fpdfapi/page/cpdf_streamcontentparser.cpp (right):

https://codereview.chromium.org/2474303003/diff/20001/core/fpdfapi/page/cpdf_...
core/fpdfapi/page/cpdf_streamcontentparser.cpp:137: const PDF_AbbrPair
PDF_InlineKeyAbbr[] = {
On 2016/11/07 14:19:54, dsinclair wrote:
> nit: Since these are all in the anonymous namespace, can we drop the PDF_
> prefixes?

Done.

[npm, 2016-11-07 16:18:45]

The CQ bit was checked by npm@chromium.org

[npm, 2016-11-07 16:18:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
dsinclair@chromium.org
Link to the patchset: https://codereview.chromium.org/2474303003/#ps40001
(title: "Remove PDF_ from namespace stuff")

[commit-bot: I haz the power, 2016-11-07 16:18:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 16:42:13]

Description was changed from

==========
Clean up fpdf_page_parsers

- The code in fpdf_page_parser is only called by CPDF_StreamContentParser, so
moved there.
- Split fpdf_page_parser_old into its two classes
- Renamed the corresponding unittests accordingly.
- Moved PDF_ReplaceAbbr to namespace
- Fixed few nits
- Added TODO because CPDF_StreamParser has a lot of code similar to
CPDF_SyntaxParser
==========

to

==========
Clean up fpdf_page_parsers

- The code in fpdf_page_parser is only called by CPDF_StreamContentParser, so
moved there.
- Split fpdf_page_parser_old into its two classes
- Renamed the corresponding unittests accordingly.
- Moved PDF_ReplaceAbbr to namespace
- Fixed few nits
- Added TODO because CPDF_StreamParser has a lot of code similar to
CPDF_SyntaxParser

Committed:
https://pdfium.googlesource.com/pdfium/+/014b012278b7438ef8d4b66730b8598c7eb4...
==========

[commit-bot: I haz the power, 2016-11-07 16:42:14]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/014b012278b7438ef8d4b66730b8598c7eb4...