Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2474283005: Revert of Unify some code (Closed)

Created:
4 years, 1 month ago by dsinclair
Modified:
4 years, 1 month ago
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Revert of Unify some code (patchset #14 id:260001 of https://codereview.chromium.org/2466023002/ ) Reason for revert: Breaking the chrome roll. See https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/331856 Original issue's description: > Unify some code > > Move parsing of linearized header into separate CPDF_Linearized class. > > Committed: https://pdfium.googlesource.com/pdfium/+/71333dc57ac7e4cf7963c83333730b3882ab371f TBR=thestig@chromium.org,brucedawson@chromium.org,art-snake@yandex-team.ru # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://pdfium.googlesource.com/pdfium/+/19cd7cc42700b844e6d9fc170a65bf7122d468b8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+210 lines, -216 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M core/fpdfapi/parser/cpdf_data_avail.h View 3 chunks +3 lines, -2 lines 0 comments Download
M core/fpdfapi/parser/cpdf_data_avail.cpp View 13 chunks +121 lines, -40 lines 0 comments Download
M core/fpdfapi/parser/cpdf_document.h View 2 chunks +1 line, -2 lines 0 comments Download
M core/fpdfapi/parser/cpdf_document.cpp View 2 chunks +15 lines, -6 lines 0 comments Download
M core/fpdfapi/parser/cpdf_document_unittest.cpp View 3 chunks +5 lines, -10 lines 0 comments Download
M core/fpdfapi/parser/cpdf_hint_tables.h View 3 chunks +6 lines, -3 lines 0 comments Download
M core/fpdfapi/parser/cpdf_hint_tables.cpp View 3 chunks +23 lines, -11 lines 0 comments Download
D core/fpdfapi/parser/cpdf_linearized.h View 1 chunk +0 lines, -55 lines 0 comments Download
D core/fpdfapi/parser/cpdf_linearized.cpp View 1 chunk +0 lines, -69 lines 0 comments Download
M core/fpdfapi/parser/cpdf_parser.h View 3 chunks +3 lines, -3 lines 0 comments Download
M core/fpdfapi/parser/cpdf_parser.cpp View 7 chunks +33 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
dsinclair
Created Revert of Unify some code
4 years, 1 month ago (2016-11-05 04:05:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2474283005/1
4 years, 1 month ago (2016-11-05 04:05:58 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://pdfium.googlesource.com/pdfium/+/19cd7cc42700b844e6d9fc170a65bf7122d468b8
4 years, 1 month ago (2016-11-05 04:06:09 UTC) #5
Lei Zhang
The fuzzers strike again. :\-
4 years, 1 month ago (2016-11-05 04:10:55 UTC) #6
Lei Zhang
On 2016/11/05 04:10:55, Lei Zhang wrote: > The fuzzers strike again. :\- :-/
4 years, 1 month ago (2016-11-05 04:11:07 UTC) #7
Lei Zhang
4 years, 1 month ago (2016-11-05 04:18:05 UTC) #8
Message was sent while issue was closed.
BTW, is there a status page for the DEPS roller? If I saw this in time, I would
have just fixed it up...

Powered by Google App Engine
This is Rietveld 408576698