Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2474243002: [Vim/YCM] Identify ObjC and ObjC++ headers. (Closed)

Created:
4 years, 1 month ago by Sidney San Martín
Modified:
4 years, 1 month ago
Reviewers:
asanka
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Vim/YCM] Identify ObjC and ObjC++ headers. Objective-C and Objective-C++ headers were all being treated as plain C++ files (with lots of syntax errors). This change adds .m and .mm to the list of extensions that our YCM config looks for to guess a header's language, and refactors the search to use Ninja instead of looking for files on disk. It also adds more tests for Obj-C{,++}. BUG= Committed: https://crrev.com/d6a698265e842542c84ac10e7cdd07f356575194 Cr-Commit-Position: refs/heads/master@{#430351}

Patch Set 1 #

Patch Set 2 : Use normal cxx for the new tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -44 lines) Patch
M tools/vim/chromium.ycm_extra_conf.py View 5 chunks +19 lines, -33 lines 0 comments Download
M tools/vim/tests/chromium.ycm_extra_conf_unittest.py View 2 chunks +20 lines, -11 lines 0 comments Download
M tools/vim/tests/data/fake_build_ninja.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Sidney San Martín
More ObjC fixes. Thanks in advance!
4 years, 1 month ago (2016-11-03 23:11:23 UTC) #7
asanka
LGTM. Thanks!
4 years, 1 month ago (2016-11-07 15:19:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2474243002/20001
4 years, 1 month ago (2016-11-07 19:36:16 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-07 19:53:18 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 20:05:03 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d6a698265e842542c84ac10e7cdd07f356575194
Cr-Commit-Position: refs/heads/master@{#430351}

Powered by Google App Engine
This is Rietveld 408576698