content/renderer/media/webrtc_local_audio_renderer.cc - Issue 24742007: When an audio track is disabled, still pass the data to webrtc for audio processing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webrtc_local_audio_renderer.cc

Issue 24742007: When an audio track is disabled, still pass the data to webrtc for audio processing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/media/webrtc_local_audio_renderer.cc

diff --git a/content/renderer/media/webrtc_local_audio_renderer.cc b/content/renderer/media/webrtc_local_audio_renderer.cc

index 9435d3321593a1c708b6fd3348ac05d170f2a2a3..c20b5613a75ef03d7e12c7f4ff4913b7dcccb014 100644

--- a/content/renderer/media/webrtc_local_audio_renderer.cc

+++ b/content/renderer/media/webrtc_local_audio_renderer.cc

@@ -69,6 +69,9 @@ int WebRtcLocalAudioRenderer::CaptureData(const std::vector<int>& channels,

bool need_audio_processing,

bool key_pressed) {

TRACE_EVENT0("audio", "WebRtcLocalAudioRenderer::CaptureData");

+ if (!current_volume)

ajm 2013/09/27 22:54:40 This seems really hacky. What if the current volum

+ return 0;

base::AutoLock auto_lock(thread_lock_);

if (!playing_ || !volume_)

return 0;

« no previous file with comments | « no previous file | content/renderer/media/webrtc_local_audio_track.cc » ('j') | content/renderer/media/webrtc_local_audio_track.cc » ('J')