Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1447)

Unified Diff: content/renderer/media/webrtc_local_audio_track.cc

Issue 24742007: When an audio track is disabled, still pass the data to webrtc for audio processing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/webrtc_local_audio_track.cc
diff --git a/content/renderer/media/webrtc_local_audio_track.cc b/content/renderer/media/webrtc_local_audio_track.cc
index 37846335e8531270c5c6c66658c400137b82bcf4..ce227367daecac8ac9c8abac4842fa023ae9f54c 100644
--- a/content/renderer/media/webrtc_local_audio_track.cc
+++ b/content/renderer/media/webrtc_local_audio_track.cc
@@ -159,8 +159,9 @@ void WebRtcLocalAudioTrack::Capture(media::AudioBus* audio_source,
// When the track is disabled, we simply return here.
// TODO(xians): Figure out if we should feed zero to sinks instead, in
// order to inject VAD data in such case.
- if (!enabled())
- return;
+ if (!enabled()) {
no longer working on chromium 2013/09/27 12:31:52 remove this if check
+ volume = 0;
no longer working on chromium 2013/09/26 20:52:31 This is wrong, it will confuse the APM that the cu
+ }
capturer = capturer_;
voe_channels = voe_channels_;

Powered by Google App Engine
This is Rietveld 408576698