Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 2474163003: Remove stl_util's deletion function use from ui/. (Closed)

Created:
4 years, 1 month ago by Avi (use Gerrit)
Modified:
4 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, ozone-reviews_chromium.org, yusukes+watch_chromium.org, tdresser+watch_chromium.org, Peter Beverloo, mlamouri+watch-notifications_chromium.org, shuchen+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, kalyank, awdf+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove stl_util's deletion function use from ui/. BUG=555865 Committed: https://crrev.com/f9e94c7d769c79f5433588f1e640dc79f5fff61f Cr-Commit-Position: refs/heads/master@{#430132}

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : fix #

Patch Set 4 : compile #

Patch Set 5 : fix #

Patch Set 6 : fix #

Total comments: 2

Patch Set 7 : braces #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -64 lines) Patch
M ui/chromeos/ime/candidate_window_view.h View 3 chunks +5 lines, -3 lines 0 comments Download
M ui/chromeos/ime/candidate_window_view.cc View 1 2 3 4 5 6 5 chunks +12 lines, -11 lines 0 comments Download
M ui/chromeos/ime/candidate_window_view_unittest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M ui/events/gestures/gesture_recognizer_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/events/gestures/gesture_recognizer_impl.cc View 1 2 9 chunks +15 lines, -23 lines 0 comments Download
M ui/events/ozone/evdev/input_device_factory_evdev.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/ozone/evdev/input_device_factory_evdev.cc View 7 chunks +6 lines, -8 lines 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/gesture_feedback.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/gesture_feedback.cc View 1 2 3 2 chunks +4 lines, -3 lines 0 comments Download
M ui/events/ozone/evdev/touch_event_converter_evdev_unittest.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M ui/events/ozone/evdev/touch_noise/touch_noise_finder.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ui/events/ozone/evdev/touch_noise/touch_noise_finder.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M ui/wm/core/transient_window_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 32 (26 generated)
Avi (use Gerrit)
4 years, 1 month ago (2016-11-04 21:32:20 UTC) #22
sky
LGTM https://codereview.chromium.org/2474163003/diff/90001/ui/chromeos/ime/candidate_window_view.cc File ui/chromeos/ime/candidate_window_view.cc (right): https://codereview.chromium.org/2474163003/diff/90001/ui/chromeos/ime/candidate_window_view.cc#newcode365 ui/chromeos/ime/candidate_window_view.cc:365: while (page_size < candidate_views_.size()) { no {}
4 years, 1 month ago (2016-11-04 23:13:33 UTC) #23
Avi (use Gerrit)
https://codereview.chromium.org/2474163003/diff/90001/ui/chromeos/ime/candidate_window_view.cc File ui/chromeos/ime/candidate_window_view.cc (right): https://codereview.chromium.org/2474163003/diff/90001/ui/chromeos/ime/candidate_window_view.cc#newcode365 ui/chromeos/ime/candidate_window_view.cc:365: while (page_size < candidate_views_.size()) { On 2016/11/04 23:13:33, sky ...
4 years, 1 month ago (2016-11-05 01:11:12 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2474163003/110001
4 years, 1 month ago (2016-11-05 01:26:14 UTC) #29
commit-bot: I haz the power
Committed patchset #7 (id:110001)
4 years, 1 month ago (2016-11-05 02:48:45 UTC) #30
commit-bot: I haz the power
4 years, 1 month ago (2016-11-05 02:51:16 UTC) #32
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/f9e94c7d769c79f5433588f1e640dc79f5fff61f
Cr-Commit-Position: refs/heads/master@{#430132}

Powered by Google App Engine
This is Rietveld 408576698