Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Issue 2474163002: [api] Remove EmbedderReachableReferenceReporter (Closed)

Created:
4 years, 1 month ago by Michael Lippautz
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[api] Remove EmbedderReachableReferenceReporter API was highly experimental. Embedders should use V8::RegisterExternalReference instead. BUG=chromium:468240 R=jochen@chromium.org Committed: https://crrev.com/5b1de36d93d8c0729422acdbd8405fe5ae8ff6bc Cr-Commit-Position: refs/heads/master@{#40769}

Patch Set 1 #

Patch Set 2 : Remove old api #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -82 lines) Patch
M include/v8.h View 1 7 chunks +32 lines, -46 lines 0 comments Download
M include/v8-util.h View 1 1 chunk +6 lines, -11 lines 0 comments Download
M src/api.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/heap/heap.h View 1 3 chunks +0 lines, -17 lines 0 comments Download
M src/heap/heap.cc View 1 2 chunks +0 lines, -4 lines 0 comments Download
M src/heap/incremental-marking.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/heap/mark-compact.cc View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 20 (13 generated)
Michael Lippautz
ptal, depends on the chromium side (https://codereview.chromium.org/2475733002/) landing first.
4 years, 1 month ago (2016-11-03 19:09:29 UTC) #5
jochen (gone - plz use gerrit)
lgtm
4 years, 1 month ago (2016-11-04 09:07:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2474163002/20001
4 years, 1 month ago (2016-11-04 11:34:23 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_chromium_gn_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/builds/27613)
4 years, 1 month ago (2016-11-04 12:08:35 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2474163002/20001
4 years, 1 month ago (2016-11-04 14:26:41 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-04 14:28:43 UTC) #18
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:23:01 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5b1de36d93d8c0729422acdbd8405fe5ae8ff6bc
Cr-Commit-Position: refs/heads/master@{#40769}

Powered by Google App Engine
This is Rietveld 408576698