Don't use url from ImageResource for computed style.

Don't use url from ImageResource for computed style.

ImageResource objects are shared between urls which only differ in
fragment identifier. The fragment identifier of the first requested url
is stored on ImageResource. That gave incorrect results when requesting
computed style values of backgroundImage for pseudo elements.

Use the url which is stored on StyleFetchedImage instead.

R=timloh@chromium.org
BUG=661998
Committed: https://crrev.com/9ed43348266eeba34ed331c5ebcd42ca3407e93d
Cr-Commit-Position: refs/heads/master@{#430246}

[rune, 2016-11-04 14:25:00]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 14:25:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rune, 2016-11-04 14:29:54]

PTAL

I added an expectation file because of the "blocked access" output. Tips on how
to avoid that output to get rid of the expectation file is welcome.

[commit-bot: I haz the power, 2016-11-04 16:06:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 16:06:33]

Dry run: This issue passed the CQ dry run.

[Timothy Loh, 2016-11-07 01:58:42]

lgtm

On 2016/11/04 14:29:54, rune wrote:
> PTAL
> 
> I added an expectation file because of the "blocked access" output. Tips on
how
> to avoid that output to get rid of the expectation file is welcome.

I assume using a relative path won't work because it will be absolutised in
getComputedStyle? Seems fine to have an expectation file.

[rune, 2016-11-07 09:11:28]

On 2016/11/07 01:58:42, Timothy Loh wrote:
> lgtm
> 
> On 2016/11/04 14:29:54, rune wrote:
> > PTAL
> > 
> > I added an expectation file because of the "blocked access" output. Tips on
> how
> > to avoid that output to get rid of the expectation file is welcome.
> 
> I assume using a relative path won't work because it will be absolutised in
> getComputedStyle? Seems fine to have an expectation file.

Yes, using a relative path included my local checkout path in the computed style
output.

[rune, 2016-11-07 09:11:36]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2016-11-07 09:11:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 10:18:39]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-07 10:21:07]

Description was changed from

==========
Don't use url from ImageResource for computed style.

ImageResource objects are shared between urls which only differ in
fragment identifier. The fragment identifier of the first requested url
is stored on ImageResource. That gave incorrect results when requesting
computed style values of backgroundImage for pseudo elements.

Use the url which is stored on StyleFetchedImage instead.

R=timloh@chromium.org
BUG=661998
==========

to

==========
Don't use url from ImageResource for computed style.

ImageResource objects are shared between urls which only differ in
fragment identifier. The fragment identifier of the first requested url
is stored on ImageResource. That gave incorrect results when requesting
computed style values of backgroundImage for pseudo elements.

Use the url which is stored on StyleFetchedImage instead.

R=timloh@chromium.org
BUG=661998

Committed: https://crrev.com/9ed43348266eeba34ed331c5ebcd42ca3407e93d
Cr-Commit-Position: refs/heads/master@{#430246}
==========

[commit-bot: I haz the power, 2016-11-07 10:21:08]

Patchset 1 (id:??) landed as
https://crrev.com/9ed43348266eeba34ed331c5ebcd42ca3407e93d
Cr-Commit-Position: refs/heads/master@{#430246}