Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: ui/events/event.cc

Issue 2474083002: [DomKey X11] Produce correct DomKey when Control is down (Closed)
Patch Set: dtapuska's review: Move #if block Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/events/event.cc
diff --git a/ui/events/event.cc b/ui/events/event.cc
index f04c842e595b3787a18aed70cb42eab4d04857e3..e82747ba32183cca73e95264af1af5345ebc8051 100644
--- a/ui/events/event.cc
+++ b/ui/events/event.cc
@@ -1227,11 +1227,7 @@ void KeyEvent::ApplyLayout() const {
// so this is a synthetic or native keystroke event.
// Therefore, perform only the fallback action.
#elif defined(USE_X11)
- // When a control key is held, prefer ASCII characters to non ASCII
- // characters in order to use it for shortcut keys. GetCharacterFromKeyCode
- // returns 'a' for VKEY_A even if the key is actually bound to 'à' in X11.
- // GetCharacterFromXEvent returns 'à' in that case.
- if (!IsControlDown() && native_event()) {
+ if (native_event()) {
key_ = GetDomKeyFromXEvent(native_event());
return;
}

Powered by Google App Engine
This is Rietveld 408576698