Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Unified Diff: third_party/WebKit/Source/core/editing/EditingBehavior.cpp

Issue 2474083002: [DomKey X11] Produce correct DomKey when Control is down (Closed)
Patch Set: Produce correct DomKey when ctrl is down Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/events/event.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/EditingBehavior.cpp
diff --git a/third_party/WebKit/Source/core/editing/EditingBehavior.cpp b/third_party/WebKit/Source/core/editing/EditingBehavior.cpp
index 54890191d8ca1b696d8bfc511afb14e7d13af7f7..93fbd1f187f5731b4169ead5554943eaf26865c9 100644
--- a/third_party/WebKit/Source/core/editing/EditingBehavior.cpp
+++ b/third_party/WebKit/Source/core/editing/EditingBehavior.cpp
@@ -278,6 +278,13 @@ bool EditingBehavior::shouldInsertCharacter(const KeyboardEvent& event) const {
return false;
#endif
}
+#if OS(LINUX)
+ // According to XKB map no keyboard combinations with ctrl key are mapped to
dtapuska 2016/11/07 22:04:37 Can we move this to be above the !OS(WIN) and chan
chongz 2016/11/07 22:44:35 Done.
+ // printable characters, however we need the filter as the DomKey/text could
+ // contain printable characters.
+ if (event.ctrlKey())
+ return false;
+#endif
#endif
return true;
« no previous file with comments | « no previous file | ui/events/event.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698