Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Unified Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

Issue 2474073005: DevTools: add the logging aspect into the PerformanceMonitor (Closed)
Patch Set: test fixed Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
diff --git a/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js b/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
index 781209df993fc52c92894440133eb93d773a0e10..dda60e39a0448e4d117aa92a5c5b9ea2bc3cf182 100644
--- a/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
+++ b/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
@@ -191,6 +191,7 @@ WebInspector.ConsoleViewMessage = class {
*/
_buildMessage(consoleMessage) {
var messageElement;
+ var messageText = consoleMessage.messageText;
if (consoleMessage.source === WebInspector.ConsoleMessage.MessageSource.ConsoleAPI) {
switch (consoleMessage.type) {
case WebInspector.ConsoleMessage.MessageType.Trace:
@@ -213,13 +214,13 @@ WebInspector.ConsoleViewMessage = class {
break;
case WebInspector.ConsoleMessage.MessageType.Profile:
case WebInspector.ConsoleMessage.MessageType.ProfileEnd:
- messageElement = this._format([consoleMessage.messageText]);
+ messageElement = this._format([messageText]);
break;
default:
if (consoleMessage.parameters && consoleMessage.parameters.length === 1 &&
consoleMessage.parameters[0].type === 'string')
messageElement = this._tryFormatAsError(/** @type {string} */ (consoleMessage.parameters[0].value));
- var args = consoleMessage.parameters || [consoleMessage.messageText];
+ var args = consoleMessage.parameters || [messageText];
messageElement = messageElement || this._format(args);
}
} else if (consoleMessage.source === WebInspector.ConsoleMessage.MessageSource.Network) {
@@ -237,14 +238,16 @@ WebInspector.ConsoleViewMessage = class {
' ', String(consoleMessage.request.statusCode), ' (', consoleMessage.request.statusText, ')');
} else {
var fragment = WebInspector.linkifyStringAsFragmentWithCustomLinkifier(
- consoleMessage.messageText, linkifyRequest.bind(consoleMessage));
+ messageText, linkifyRequest.bind(consoleMessage));
messageElement.appendChild(fragment);
}
} else {
- messageElement = this._format([consoleMessage.messageText]);
+ messageElement = this._format([messageText]);
}
} else {
- var args = consoleMessage.parameters || [consoleMessage.messageText];
+ if (consoleMessage.source === WebInspector.ConsoleMessage.MessageSource.Violation)
+ messageText = WebInspector.UIString('[Violation] %s', messageText);
+ var args = consoleMessage.parameters || [messageText];
messageElement = this._format(args);
}
messageElement.classList.add('console-message-text');

Powered by Google App Engine
This is Rietveld 408576698