DevTools: add the logging aspect into the PerformanceMonitor

third_party/WebKit/Source/core/events/EventTarget.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
  * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  *           (C) 2007, 2008 Nikolas Zimmermann <zimmermann@kde.org>
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ skipping 24 matching lines @@
 #include "bindings/core/v8/ScriptEventListener.h"
 #include "bindings/core/v8/SourceLocation.h"
 #include "bindings/core/v8/V8DOMActivityLogger.h"
 #include "core/dom/ExceptionCode.h"
 #include "core/editing/Editor.h"
 #include "core/events/Event.h"
 #include "core/events/EventUtil.h"
 #include "core/events/PointerEvent.h"
 #include "core/frame/FrameHost.h"
 #include "core/frame/LocalDOMWindow.h"
+#include "core/frame/PerformanceMonitor.h"
 #include "core/frame/Settings.h"
 #include "core/frame/UseCounter.h"
-#include "core/inspector/ConsoleMessage.h"
 #include "core/inspector/InspectorInstrumentation.h"
 #include "platform/EventDispatchForbiddenScope.h"
 #include "platform/Histogram.h"
 #include "wtf/PtrUtil.h"
 #include "wtf/StdLibExtras.h"
 #include "wtf/Threading.h"
 #include "wtf/Vector.h"
 #include <memory>
 
 using namespace WTF;
@@ skipping 29 matching lines @@
   return eventType == EventTypeNames::touchstart ||
          eventType == EventTypeNames::touchmove;
 }
 
 bool isScrollBlockingEvent(const AtomicString& eventType) {
   return isTouchScrollBlockingEvent(eventType) ||
          eventType == EventTypeNames::mousewheel ||
          eventType == EventTypeNames::wheel;
 }
 
-double blockedEventsWarningThreshold(const ExecutionContext* context,
-                                     const Event* event) {
+double blockedEventsWarningThreshold(ExecutionContext* context, Event* event) {
   if (!event->cancelable())
     return 0.0;
   if (!isScrollBlockingEvent(event->type()))
     return 0.0;
 
-  if (!context->isDocument())
-    return 0.0;
-  FrameHost* frameHost = toDocument(context)->frameHost();
-  if (!frameHost)
-    return 0.0;
-  return frameHost->settings().blockedMainThreadEventsWarningThreshold();
+  return PerformanceMonitor::enabled(context) ? 0.1 : 0;

[caseq, 2016/11/05 00:14:35]

Extract constant for 0.1

[pfeldman, 2016/11/05 00:16:02]

Done.

 }
 
 void reportBlockedEvent(ExecutionContext* context,
                         const Event* event,
                         RegisteredEventListener* registeredListener,
                         double delayedSeconds) {
   if (registeredListener->listener()->type() !=
       EventListener::JSEventListenerType)
     return;
 
@@ skipping 10 matching lines @@
       "Handling of '%s' input event was delayed for %ld ms due to main thread "
       "being busy. "
       "Consider marking event handler as 'passive' to make the page more "
       "responsive.",
       event->type().getString().utf8().data(), lround(delayedSeconds * 1000));
 
   v8::Local<v8::Function> function =
       eventListenerEffectiveFunction(v8Listener->isolate(), handler);
   std::unique_ptr<SourceLocation> location =
       SourceLocation::fromFunction(function);
-  ConsoleMessage* message = ConsoleMessage::create(
-      JSMessageSource, WarningMessageLevel, messageText, std::move(location));
-  context->addConsoleMessage(message);
+  PerformanceMonitor::logViolation(WarningMessageLevel, context, messageText,
+                                   std::move(location));
   registeredListener->setBlockedEventWarningEmitted();
 }
 
 }  // namespace
 
 EventTargetData::EventTargetData() {}
 
 EventTargetData::~EventTargetData() {}
 
 DEFINE_TRACE(EventTargetData) {
@@ skipping 606 matching lines @@
   // they have one less listener to invoke.
   if (d->firingEventIterators) {
     for (size_t i = 0; i < d->firingEventIterators->size(); ++i) {
       d->firingEventIterators->at(i).iterator = 0;
       d->firingEventIterators->at(i).end = 0;
     }
   }
 }
 
 }  // namespace blink