Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Side by Side Diff: third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp

Issue 2474073005: DevTools: add the logging aspect into the PerformanceMonitor (Closed)
Patch Set: test fixed Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010-2011 Google Inc. All rights reserved. 2 * Copyright (C) 2010-2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 412 matching lines...) Expand 10 before | Expand all | Expand 10 after
423 423
424 m_session->append(InspectorInputAgent::create(m_inspectedFrames.get())); 424 m_session->append(InspectorInputAgent::create(m_inspectedFrames.get()));
425 425
426 InspectorPageAgent* pageAgent = InspectorPageAgent::create( 426 InspectorPageAgent* pageAgent = InspectorPageAgent::create(
427 m_inspectedFrames.get(), this, m_resourceContentLoader.get(), 427 m_inspectedFrames.get(), this, m_resourceContentLoader.get(),
428 m_session->v8Session()); 428 m_session->v8Session());
429 m_pageAgent = pageAgent; 429 m_pageAgent = pageAgent;
430 m_session->append(pageAgent); 430 m_session->append(pageAgent);
431 431
432 m_session->append(new InspectorLogAgent( 432 m_session->append(new InspectorLogAgent(
433 &m_inspectedFrames->root()->host()->consoleMessageStorage())); 433 &m_inspectedFrames->root()->host()->consoleMessageStorage(),
434 m_inspectedFrames->root()->performanceMonitor()));
434 435
435 m_tracingAgent->setLayerTreeId(m_layerTreeId); 436 m_tracingAgent->setLayerTreeId(m_layerTreeId);
436 m_networkAgent->setHostId(hostId); 437 m_networkAgent->setHostId(hostId);
437 438
438 if (m_includeViewAgents) { 439 if (m_includeViewAgents) {
439 // TODO(dgozman): we should actually pass the view instead of frame, but 440 // TODO(dgozman): we should actually pass the view instead of frame, but
440 // during remote->local transition we cannot access mainFrameImpl() yet, so 441 // during remote->local transition we cannot access mainFrameImpl() yet, so
441 // we have to store the frame which will become the main frame later. 442 // we have to store the frame which will become the main frame later.
442 m_session->append( 443 m_session->append(
443 InspectorRenderingAgent::create(m_webLocalFrameImpl, m_overlay.get())); 444 InspectorRenderingAgent::create(m_webLocalFrameImpl, m_overlay.get()));
(...skipping 255 matching lines...) Expand 10 before | Expand all | Expand 10 after
699 } 700 }
700 701
701 bool WebDevToolsAgent::shouldInterruptForMethod(const WebString& method) { 702 bool WebDevToolsAgent::shouldInterruptForMethod(const WebString& method) {
702 return method == "Debugger.pause" || method == "Debugger.setBreakpoint" || 703 return method == "Debugger.pause" || method == "Debugger.setBreakpoint" ||
703 method == "Debugger.setBreakpointByUrl" || 704 method == "Debugger.setBreakpointByUrl" ||
704 method == "Debugger.removeBreakpoint" || 705 method == "Debugger.removeBreakpoint" ||
705 method == "Debugger.setBreakpointsActive"; 706 method == "Debugger.setBreakpointsActive";
706 } 707 }
707 708
708 } // namespace blink 709 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698