Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2474073002: Revert of Try to use only std::aligned_storage. (Closed)

Created:
4 years, 1 month ago by dogben
Modified:
4 years, 1 month ago
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Try to use only std::aligned_storage. (patchset #2 id:20001 of https://codereview.chromium.org/2468243002/ ) Reason for revert: DM failure: https://luci-milo.appspot.com/swarming/task/324387bf30100f10 c:\b\work\skia\src\core\sklinearbitmappipeline.cpp:49: fatal error: "assert(sizeof(Variant) <= sizeof(fSpace))" Original issue's description: > Try to use only std::aligned_storage. This does not change the API. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2468243002 > TBR=reed@google.com > > Committed: https://skia.googlesource.com/skia/+/e736e0c2d52a29a3b88a29ab39b3a90a5a2443a0 TBR=mtklein@chromium.org,bsalomon@google.com,mtklein@google.com,reed@google.com,herb@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/dc46bf10ae380914a3f81053e5a60e9c28409ec4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -12 lines) Patch
M include/core/SkPostConfig.h View 1 chunk +9 lines, -0 lines 0 comments Download
M src/core/SkLinearBitmapPipeline.h View 3 chunks +10 lines, -7 lines 0 comments Download
M src/core/SkSmallAllocator.h View 2 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
dogben
Created Revert of Try to use only std::aligned_storage.
4 years, 1 month ago (2016-11-03 15:08:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2474073002/1
4 years, 1 month ago (2016-11-03 15:08:19 UTC) #3
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 15:08:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/dc46bf10ae380914a3f81053e5a60e9c28409ec4

Powered by Google App Engine
This is Rietveld 408576698