Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1280)

Issue 2474043002: Tidy up ComputedStyle::applyTransform (Closed)

Created:
4 years, 1 month ago by fs
Modified:
4 years, 1 month ago
Reviewers:
Stephen Chennney, pdr.
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Tidy up ComputedStyle::applyTransform Use range-based for-loops when iterating transform operations (also in ComputedStyle::requireTransformOrigin), since it's both tidier and avoids unnecessary index-checks (in operator[].) Move computation of offsetX/offsetY closer to their point of usage. Extract the size of the bounding box once, and also drop some unneeded qualifications of enumeration values. BUG=369942 Committed: https://crrev.com/4ae2f78aa839eb6243f84152033d5e740562b10b Cr-Commit-Position: refs/heads/master@{#429598}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -21 lines) Patch
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 4 chunks +14 lines, -21 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
fs
4 years, 1 month ago (2016-11-03 14:47:31 UTC) #4
Stephen Chennney
lgtm
4 years, 1 month ago (2016-11-03 15:41:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2474043002/1
4 years, 1 month ago (2016-11-03 15:41:45 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-03 15:48:58 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 16:11:47 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4ae2f78aa839eb6243f84152033d5e740562b10b
Cr-Commit-Position: refs/heads/master@{#429598}

Powered by Google App Engine
This is Rietveld 408576698