Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Issue 2474023002: PPC/s390: [builtins]: Uniformly push argument count in TF-generated builtins (Closed)

Created:
4 years, 1 month ago by JaideepBajwa
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [builtins]: Uniformly push argument count in TF-generated builtins Port 4447405b179db63748c10d8cb3d139e795195eb3 R=danno@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= LOG=N Committed: https://crrev.com/e81c410c7cc23bb6cdbcb4702ecd7b66e513b8df Cr-Commit-Position: refs/heads/master@{#40731}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M src/compiler/ppc/code-generator-ppc.cc View 2 chunks +5 lines, -1 line 0 comments Download
M src/compiler/s390/code-generator-s390.cc View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
JaideepBajwa
PTAL
4 years, 1 month ago (2016-11-03 12:16:19 UTC) #1
john.yan
lgtm
4 years, 1 month ago (2016-11-03 14:36:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2474023002/1
4 years, 1 month ago (2016-11-03 14:40:32 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-03 15:05:02 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:20:52 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e81c410c7cc23bb6cdbcb4702ecd7b66e513b8df
Cr-Commit-Position: refs/heads/master@{#40731}

Powered by Google App Engine
This is Rietveld 408576698