Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 2474013002: [turbofan] CheckBounds cannot be used within asm.js. (Closed)

Created:
4 years, 1 month ago by Benedikt Meurer
Modified:
4 years, 1 month ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] CheckBounds cannot be used within asm.js. Also properly deal with constant indices for String element access in the JSNativeContextSpecialization. BUG=chromium:661949 R=jarin@chromium.org Committed: https://crrev.com/10033749fdb0d2907295b572ab8c4abd8e118169 Cr-Commit-Position: refs/heads/master@{#40723}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -20 lines) Patch
M src/compiler/js-native-context-specialization.cc View 1 chunk +23 lines, -13 lines 0 comments Download
M src/compiler/node-matchers.h View 1 chunk +3 lines, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-661949.js View 1 chunk +6 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Benedikt Meurer
4 years, 1 month ago (2016-11-03 12:09:50 UTC) #1
Jarin
lgtm
4 years, 1 month ago (2016-11-03 12:11:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2474013002/1
4 years, 1 month ago (2016-11-03 12:11:42 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-03 12:34:53 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:20:31 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/10033749fdb0d2907295b572ab8c4abd8e118169
Cr-Commit-Position: refs/heads/master@{#40723}

Powered by Google App Engine
This is Rietveld 408576698