src/factory.cc - Issue 2473993002: [modules] Make handling of module info's regular exports more robust.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/factory.cc

Issue 2473993002: [modules] Make handling of module info's regular exports more robust. (Closed)

Patch Set: cast size_t Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/factory.cc

diff --git a/src/factory.cc b/src/factory.cc

index 2b55c025198688937e594d186688534b45536ea2..a1ec9324b0c7cb7aed0bdeed83208331457808fb 100644

--- a/src/factory.cc

+++ b/src/factory.cc

@@ -1816,7 +1816,7 @@ Handle<Module> Factory::NewModule(Handle<SharedFunctionInfo> code) {

Handle<ModuleInfo> module_info(code->scope_info()->ModuleDescriptorInfo(),

isolate());

Handle<ObjectHashTable> exports =

- ObjectHashTable::New(isolate(), module_info->regular_exports()->length());

+ ObjectHashTable::New(isolate(), module_info->RegularExportCount());

int requested_modules_length = module_info->module_requests()->length();

Handle<FixedArray> requested_modules =

requested_modules_length > 0 ? NewFixedArray(requested_modules_length)

« no previous file with comments | « src/ast/scopes.cc ('k') | src/objects.h » ('j') | no next file with comments »