Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(940)

Issue 2473983003: Use share group tracing ID for renderbuffer memory dump (Closed)

Created:
4 years, 1 month ago by ericrk
Modified:
4 years, 1 month ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, piman+watch_chromium.org, Primiano Tucci (use gerrit)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use share group tracing ID for renderbuffer memory dump We previously used client id. This is not guaranteed to be unique. Use the share group tracing ID instead. BUG=661436 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/b03ea3889fdf345f5042a3112e2585266a951ebe Cr-Commit-Position: refs/heads/master@{#430058}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M gpu/command_buffer/service/renderbuffer_manager.cc View 1 3 chunks +11 lines, -8 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
ericrk
4 years, 1 month ago (2016-11-03 18:28:13 UTC) #3
ericrk
4 years, 1 month ago (2016-11-03 18:28:25 UTC) #4
Zhenyao Mo
lgtm
4 years, 1 month ago (2016-11-03 20:47:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2473983003/20001
4 years, 1 month ago (2016-11-04 21:20:28 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-04 23:09:11 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 23:12:57 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b03ea3889fdf345f5042a3112e2585266a951ebe
Cr-Commit-Position: refs/heads/master@{#430058}

Powered by Google App Engine
This is Rietveld 408576698