Fix java target naming exceptions in third_party/

third_party/robolectric/BUILD.gn

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/android/rules.gni")
 
 java_group("robolectric_all_java") {
   testonly = true
   deps = [
-    ":android-all-5.0.0_r2-robolectric-1",
+    ":android-all-5.0.0_r2-robolectric-1_java",
     ":robolectric_annotations_java",
     ":robolectric_java",
     ":robolectric_resources_java",
     ":robolectric_utils_java",
-    ":shadows-core-3.0-21",
-    ":shadows-multidex-3.0",
+    ":shadows-core-3.0-21_java",
+    ":shadows-multidex-3.0_java",
   ]
 }
 
-java_prebuilt("tagsoup-1.2") {
+java_prebuilt("tagsoup-1.2_java") {
   testonly = true
   jar_path = "lib/tagsoup-1.2.jar"
 }
 
-java_prebuilt("json-20080701") {
+java_prebuilt("json-20080701_java") {
   testonly = true
   jar_path = "lib/json-20080701.jar"
 }
 
-java_prebuilt("android-all-4.3_r2-robolectric-0") {
+java_prebuilt("android-all-4.3_r2-robolectric-0_java") {
   testonly = true
   jar_path = "lib/android-all-4.3_r2-robolectric-0.jar"
 }
 
-java_prebuilt("android-all-5.0.0_r2-robolectric-1") {
+java_prebuilt("android-all-5.0.0_r2-robolectric-1_java") {
   testonly = true
   jar_path = "lib/android-all-5.0.0_r2-robolectric-1.jar"
 }
 
 java_library("robolectric_java") {
   testonly = true
   deps = [
-    ":android-all-5.0.0_r2-robolectric-1",
-    ":json-20080701",
+    ":android-all-5.0.0_r2-robolectric-1_java",
+    ":json-20080701_java",
     ":robolectric_annotations_java",
     ":robolectric_resources_java",
     ":robolectric_utils_java",
-    ":shadows-core-3.0-18",
-    ":shadows-core-3.0-21",
-    ":shadows-multidex-3.0",
-    ":tagsoup-1.2",
+    ":shadows-core-3.0-18_java",
+    ":shadows-core-3.0-21_java",
+    ":shadows-multidex-3.0_java",
+    ":tagsoup-1.2_java",
     "//third_party/bouncycastle:bouncycastle_java",
     "//third_party/icu4j:icu4j_java",
     "//third_party/intellij:intellij_annotations_java",
     "//third_party/junit:junit",
     "//third_party/ow2_asm:asm_analysis_java",
     "//third_party/ow2_asm:asm_commons_java",
     "//third_party/ow2_asm:asm_java",
     "//third_party/ow2_asm:asm_tree_java",
     "//third_party/ow2_asm:asm_util_java",
     "//third_party/sqlite4java:sqlite4java_java",
@@ skipping 49 matching lines @@
   additional_jar_files = [ [
         rebase_path(
             "robolectric/robolectric/src/main/resources/robolectric-version.properties"),
         "robolectric-version.properties",
       ] ]
 }
 
 java_library("robolectric_annotations_java") {
   testonly = true
   deps = [
-    ":android-all-5.0.0_r2-robolectric-1",
+    ":android-all-5.0.0_r2-robolectric-1_java",
     "//third_party/intellij:intellij_annotations_java",
   ]
   java_files = [
     "robolectric/robolectric-annotations/src/main/java/org/robolectric/annotation/AccessibilityChecks.java",
     "robolectric/robolectric-annotations/src/main/java/org/robolectric/annotation/Config.java",
     "robolectric/robolectric-annotations/src/main/java/org/robolectric/annotation/HiddenApi.java",
     "robolectric/robolectric-annotations/src/main/java/org/robolectric/annotation/Implementation.java",
     "robolectric/robolectric-annotations/src/main/java/org/robolectric/annotation/Implements.java",
     "robolectric/robolectric-annotations/src/main/java/org/robolectric/annotation/RealObject.java",
     "robolectric/robolectric-annotations/src/main/java/org/robolectric/annotation/Resetter.java",
@@ skipping 26 matching lines @@
     "robolectric/robolectric-processor/src/main/java/org/robolectric/annotation/processing/validator/RealObjectValidator.java",
     "robolectric/robolectric-processor/src/main/java/org/robolectric/annotation/processing/validator/ResetterValidator.java",
     "robolectric/robolectric-processor/src/main/java/org/robolectric/annotation/processing/validator/Validator.java",
     "robolectric/robolectric-processor/src/main/java/org/robolectric/annotation/processing/validator/package-info.java",
   ]
 }
 
 java_library("robolectric_resources_java") {
   testonly = true
   deps = [
-    ":android-all-5.0.0_r2-robolectric-1",
+    ":android-all-5.0.0_r2-robolectric-1_java",
     ":robolectric_annotations_java",
     ":robolectric_utils_java",
     "//third_party/intellij:intellij_annotations_java",
   ]
   java_files = [
     "robolectric/robolectric-resources/src/main/java/org/robolectric/RuntimeEnvironment.java",
     "robolectric/robolectric-resources/src/main/java/org/robolectric/ShadowsAdapter.java",
     "robolectric/robolectric-resources/src/main/java/org/robolectric/manifest/ActivityData.java",
     "robolectric/robolectric-resources/src/main/java/org/robolectric/manifest/AndroidManifest.java",
     "robolectric/robolectric-resources/src/main/java/org/robolectric/manifest/BroadcastReceiverData.java",
@@ skipping 49 matching lines @@
     "robolectric/robolectric-resources/src/main/java/org/robolectric/shadows/Converter.java",
     "robolectric/robolectric-resources/src/main/java/org/robolectric/shadows/ResourceHelper.java",
     "robolectric/robolectric-resources/src/main/java/org/robolectric/shadows/RoboAttributeSet.java",
     "robolectric/robolectric-resources/src/main/java/org/robolectric/shadows/RoboLayoutInflater.java",
   ]
 }
 
 java_library("robolectric_utils_java") {
   testonly = true
   deps = [
-    ":android-all-5.0.0_r2-robolectric-1",
+    ":android-all-5.0.0_r2-robolectric-1_java",
     ":robolectric_annotations_java",
     "//third_party/accessibility_test_framework:accessibility_test_framework_java",
     "//third_party/hamcrest:hamcrest_core_java",
     "//third_party/hamcrest:hamcrest_integration_java",
     "//third_party/junit:junit",
     "//third_party/ow2_asm:asm_commons_java",
     "//third_party/ow2_asm:asm_java",
   ]
   java_files = [
     "robolectric/robolectric-utils/src/main/java/org/robolectric/internal/Shadow.java",
@@ skipping 285 matching lines @@
     "template_processor/src/org/chromium/testing/robolectric/template/TemplateFileInfo.java",
   ]
   main_class =
       "org.chromium.testing.robolectric.template.ProcessRobolectricTemplate"
   deps = [
     "//third_party/apache_velocity:apache_velocity_java",
   ]
 }
 
 template("shadows_core") {
-  forward_variables_from(invoker,
-                         [
-                           "api_level",
-                           "android_sdk_deps",
-                         ])
   testonly = true
 
   _shadows_core_java_files = invoker.shadows_core_java_files
   _template_files = invoker.template_files
-  _process_templates_target_name = "${target_name}__process_templates"
+  _process_templates_target_name =
+      "shadows_core_${invoker.api_level}__process_templates"
 
   _processed_template_files = []
   _template_file_args = []
   foreach(template_file, _template_files) {
     _gen_dir = get_path_info(template_file, "gen_dir")
     _name = get_path_info(template_file, "name")
-    _output_file = "$_gen_dir/$api_level/$_name"
+    _output_file = "$_gen_dir/${invoker.api_level}/$_name"
     _template_file_args += [
       "--process-file",
       "$template_file",
       rebase_path(_output_file, root_build_dir),
     ]
     _processed_template_files += [ _output_file ]
   }
 
   action(_process_templates_target_name) {
     _base_template_dir = rebase_path(".", root_build_dir)
     script = "$root_build_dir/bin/robolectric_template_processor"
     args = [
       "--api-level",
-      "$api_level",
+      "${invoker.api_level}",
       "--base-template-dir",
       _base_template_dir,
     ]
     args += _template_file_args
 
     inputs = _template_files
     outputs = _processed_template_files
 
     deps = [
       ":robolectric_template_processor",
@@ skipping 50 matching lines @@
       ":robolectric_annotations_java",
       ":robolectric_processor_java",
       ":robolectric_resources_java",
       ":robolectric_utils_java",
       "//build/android:sun_tools_java",
       "//third_party/guava:guava_java",
       "//third_party/icu4j:icu4j_java",
       "//third_party/intellij:intellij_annotations_java",
       "//third_party/sqlite4java:sqlite4java_java",
     ]
-    deps += android_sdk_deps
+    deps += invoker.android_sdk_deps
   }
 }
 
-shadows_core("shadows-core-3.0-21") {
+shadows_core("shadows-core-3.0-21_java") {
   api_level = 21
-  android_sdk_deps = [ ":android-all-5.0.0_r2-robolectric-1" ]
+  android_sdk_deps = [ ":android-all-5.0.0_r2-robolectric-1_java" ]
 }
 
-shadows_core("shadows-core-3.0-18") {
+shadows_core("shadows-core-3.0-18_java") {
   api_level = 18
-  android_sdk_deps = [ ":android-all-4.3_r2-robolectric-0" ]
+  android_sdk_deps = [ ":android-all-4.3_r2-robolectric-0_java" ]
 }
 
-java_library("shadows-multidex-3.0") {
+java_library("shadows-multidex-3.0_java") {
   testonly = true
   processors_javac =
       [ "org.robolectric.annotation.processing.RobolectricProcessor" ]
   processor_args_javac = [ "org.robolectric.annotation.processing.shadowPackage=org.robolectric.shadows.multidex" ]
   provider_configurations = [ "robolectric/robolectric-shadows/shadows-multidex/src/main/resources/META-INF/services/org.robolectric.internal.ShadowProvider" ]
   java_files = [
     "robolectric/robolectric-shadows/shadows-multidex/src/main/java/org/robolectric/shadows/multidex/ShadowMultiDex.java",
     "robolectric/robolectric-shadows/shadows-multidex/src/main/java/org/robolectric/shadows/multidex/package-info.java",
   ]
 
   deps = [
-    ":android-all-5.0.0_r2-robolectric-1",
+    ":android-all-5.0.0_r2-robolectric-1_java",
     ":robolectric_annotations_java",
     ":robolectric_processor_java",
     ":robolectric_utils_java",
     "//build/android:sun_tools_java",
     "//third_party/android_tools:android_support_multidex_java",
     "//third_party/guava:guava_java",
   ]
 }