Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Side by Side Diff: build/config/android/rules.gni

Issue 2473963003: Fix java target naming exceptions in third_party/ (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # Do not add any imports to non-//build directories here. 5 # Do not add any imports to non-//build directories here.
6 # Some projects (e.g. V8) do not have non-build directories DEPS'ed in. 6 # Some projects (e.g. V8) do not have non-build directories DEPS'ed in.
7 import("//build/config/android/config.gni") 7 import("//build/config/android/config.gni")
8 import("//build/config/android/internal_rules.gni") 8 import("//build/config/android/internal_rules.gni")
9 import("//build/config/compiler/compiler.gni") 9 import("//build/config/compiler/compiler.gni")
10 import("//build/config/dcheck_always_on.gni") 10 import("//build/config/dcheck_always_on.gni")
(...skipping 1593 matching lines...) Expand 10 before | Expand all | Expand 10 after
1604 android_manifest = _android_manifest 1604 android_manifest = _android_manifest
1605 1605
1606 deps = _android_manifest_deps 1606 deps = _android_manifest_deps
1607 1607
1608 if (defined(invoker.deps)) { 1608 if (defined(invoker.deps)) {
1609 possible_config_deps = invoker.deps 1609 possible_config_deps = invoker.deps
1610 } 1610 }
1611 1611
1612 # Added emma to the target's classpath via its .build_config. 1612 # Added emma to the target's classpath via its .build_config.
1613 if (emma_coverage && !_emma_never_instrument) { 1613 if (emma_coverage && !_emma_never_instrument) {
1614 possible_config_deps += [ "//third_party/android_tools:emma_device" ] 1614 possible_config_deps +=
1615 [ "//third_party/android_tools:emma_device_java" ]
1615 } 1616 }
1616 1617
1617 proguard_enabled = _proguard_enabled 1618 proguard_enabled = _proguard_enabled
1618 if (_proguard_enabled) { 1619 if (_proguard_enabled) {
1619 proguard_info = "$_proguard_output_jar_path.info" 1620 proguard_info = "$_proguard_output_jar_path.info"
1620 } 1621 }
1621 1622
1622 # Don't depend on the runtime_deps target in order to avoid having to 1623 # Don't depend on the runtime_deps target in order to avoid having to
1623 # build the native libraries just to create the .build_config file. 1624 # build the native libraries just to create the .build_config file.
1624 # The dep is unnecessary since the runtime_deps file is created by gn gen 1625 # The dep is unnecessary since the runtime_deps file is created by gn gen
(...skipping 144 matching lines...) Expand 10 before | Expand all | Expand 10 after
1769 dex_path = _lib_dex_path 1770 dex_path = _lib_dex_path
1770 emma_never_instrument = _emma_never_instrument 1771 emma_never_instrument = _emma_never_instrument
1771 1772
1772 if (defined(invoker.deps)) { 1773 if (defined(invoker.deps)) {
1773 deps += invoker.deps 1774 deps += invoker.deps
1774 } 1775 }
1775 if (defined(invoker.apk_under_test)) { 1776 if (defined(invoker.apk_under_test)) {
1776 deps += [ "${invoker.apk_under_test}__java" ] 1777 deps += [ "${invoker.apk_under_test}__java" ]
1777 } 1778 }
1778 if (emma_coverage && !_emma_never_instrument) { 1779 if (emma_coverage && !_emma_never_instrument) {
1779 deps += [ "//third_party/android_tools:emma_device" ] 1780 deps += [ "//third_party/android_tools:emma_device_java" ]
1780 } 1781 }
1781 } 1782 }
1782 1783
1783 # TODO(cjhopman): This is only ever needed to calculate the list of tests to 1784 # TODO(cjhopman): This is only ever needed to calculate the list of tests to
1784 # run. See build/android/pylib/instrumentation/test_jar.py. We should be 1785 # run. See build/android/pylib/instrumentation/test_jar.py. We should be
1785 # able to just do that calculation at build time instead. 1786 # able to just do that calculation at build time instead.
1786 if (defined(invoker.create_dist_ijar) && invoker.create_dist_ijar) { 1787 if (defined(invoker.create_dist_ijar) && invoker.create_dist_ijar) {
1787 _dist_ijar_path = "$root_build_dir/test.lib.java/" + 1788 _dist_ijar_path = "$root_build_dir/test.lib.java/" +
1788 get_path_info(_final_apk_path, "name") + ".jar" 1789 get_path_info(_final_apk_path, "name") + ".jar"
1789 action("${_template_name}_dist_ijar") { 1790 action("${_template_name}_dist_ijar") {
(...skipping 969 matching lines...) Expand 10 before | Expand all | Expand 10 after
2759 # because in practice they seem to contain classes required to be in the 2760 # because in practice they seem to contain classes required to be in the
2760 # classpath. 2761 # classpath.
2761 deps += _subjar_targets 2762 deps += _subjar_targets
2762 } 2763 }
2763 if (defined(_res_target_name)) { 2764 if (defined(_res_target_name)) {
2764 deps += [ ":$_res_target_name" ] 2765 deps += [ ":$_res_target_name" ]
2765 } 2766 }
2766 } 2767 }
2767 } 2768 }
2768 } 2769 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698