Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2473963002: Merged: Math.sign fixes (Squashed multiple commits). (Closed)

Created:
4 years, 1 month ago by Jarin
Modified:
4 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, ulan
Target Ref:
refs/pending/branch-heads/5.4
Project:
v8
Visibility:
Public.

Description

Merged: Math.sign fixes (Squashed multiple commits). Merged: [turbofan] Fix Math.sign. Revision: 39d65198ed6e2c6d338f83cce78b4716cade32b8 Merged: [turbofan] Fix typing rule for Math.sign. Revision: 25504a220f75f88b565cf36df73c00e5f2702c65 NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=bmeurer@chromium.org BUG=chromium:658114 Committed: https://chromium.googlesource.com/v8/v8/+/d105cb6ca33b4632d96b99de525b12db37bc4995

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -3 lines) Patch
M src/compiler/simplified-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/typer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/type-cache.h View 1 chunk +3 lines, -1 line 0 comments Download
A test/mjsunit/compiler/math-sign.js View 1 chunk +51 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Jarin
4 years, 1 month ago (2016-11-03 05:29:14 UTC) #1
Jarin
NOTE: This script will no longer automatically update include/v8-version.h and create a tag. This is ...
4 years, 1 month ago (2016-11-03 05:29:15 UTC) #2
Benedikt Meurer
lgtm
4 years, 1 month ago (2016-11-03 05:29:59 UTC) #3
Jarin
4 years, 1 month ago (2016-11-03 05:32:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d105cb6ca33b4632d96b99de525b12db37bc4995.

Powered by Google App Engine
This is Rietveld 408576698