Don't let a column spanner affect the self-margin-collapsing state of the parent.

Don't let a column spanner affect the self-margin-collapsing state of the parent.

When a spanner is removed from the tree, we mark the container chain for
layout, just like we do when removing any other kind of object. The container
of a spanner is the multicol container, though, so the direct parent of the
spanner may not be marked for layout. And that should not be necessary either,
since the spanner is essentially taken out of normal flow.

We get some marking for layout for free in layoutBlockFlow(), if
pageLogicalHeightChanged, but that only goes one level deep. Eliminate the need
for layout in situations like this.

Prior to this change, we'd fail on an assert that required that the cached
state of self-collapsing be in sync with reality.

Committed: https://crrev.com/b8a54c69086b8c5210ca896e3b6a7e924c84ae5a
Cr-Commit-Position: refs/heads/master@{#429638}

[mstensho (USE GERRIT), 2016-11-03 10:58:00]

The CQ bit was checked by mstensho@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 10:58:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 12:07:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 12:07:24]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[mstensho (USE GERRIT), 2016-11-03 12:16:24]

mstensho@opera.com changed reviewers:
+ eae@chromium.org, szager@chromium.org

[mstensho (USE GERRIT), 2016-11-03 12:16:24]

Before I can refactor layoutBlockFlow() in
https://codereview.chromium.org/2471623003/ , I'd like to clean up some
pagination stuff there. In particular, I'd like to get rid of relayoutChildren
being set if  pageLogicalHeightChanged. Currently, when removing that, some
tests start to fail. Here's one of the fixes required.

[eae, 2016-11-03 16:14:07]

OK, LGTM

[mstensho (USE GERRIT), 2016-11-03 16:27:40]

The CQ bit was checked by mstensho@opera.com

[commit-bot: I haz the power, 2016-11-03 16:28:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 17:44:39]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-03 17:48:22]

Description was changed from

==========
Don't let a column spanner affect the self-margin-collapsing state of the
parent.

When a spanner is removed from the tree, we mark the container chain for
layout, just like we do when removing any other kind of object. The container
of a spanner is the multicol container, though, so the direct parent of the
spanner may not be marked for layout. And that should not be necessary either,
since the spanner is essentially taken out of normal flow.

We get some marking for layout for free in layoutBlockFlow(), if
pageLogicalHeightChanged, but that only goes one level deep. Eliminate the need
for layout in situations like this.

Prior to this change, we'd fail on an assert that required that the cached
state of self-collapsing be in sync with reality.
==========

to

==========
Don't let a column spanner affect the self-margin-collapsing state of the
parent.

When a spanner is removed from the tree, we mark the container chain for
layout, just like we do when removing any other kind of object. The container
of a spanner is the multicol container, though, so the direct parent of the
spanner may not be marked for layout. And that should not be necessary either,
since the spanner is essentially taken out of normal flow.

We get some marking for layout for free in layoutBlockFlow(), if
pageLogicalHeightChanged, but that only goes one level deep. Eliminate the need
for layout in situations like this.

Prior to this change, we'd fail on an assert that required that the cached
state of self-collapsing be in sync with reality.

Committed: https://crrev.com/b8a54c69086b8c5210ca896e3b6a7e924c84ae5a
Cr-Commit-Position: refs/heads/master@{#429638}
==========

[commit-bot: I haz the power, 2016-11-03 17:48:23]

Patchset 1 (id:??) landed as
https://crrev.com/b8a54c69086b8c5210ca896e3b6a7e924c84ae5a
Cr-Commit-Position: refs/heads/master@{#429638}