Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2473953003: Don't let a column spanner affect the self-margin-collapsing state of the parent. (Closed)

Created:
4 years, 1 month ago by mstensho (USE GERRIT)
Modified:
4 years, 1 month ago
Reviewers:
eae, szager1
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews, mstensho (USE GERRIT)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't let a column spanner affect the self-margin-collapsing state of the parent. When a spanner is removed from the tree, we mark the container chain for layout, just like we do when removing any other kind of object. The container of a spanner is the multicol container, though, so the direct parent of the spanner may not be marked for layout. And that should not be necessary either, since the spanner is essentially taken out of normal flow. We get some marking for layout for free in layoutBlockFlow(), if pageLogicalHeightChanged, but that only goes one level deep. Eliminate the need for layout in situations like this. Prior to this change, we'd fail on an assert that required that the cached state of self-collapsing be in sync with reality. Committed: https://crrev.com/b8a54c69086b8c5210ca896e3b6a7e924c84ae5a Cr-Commit-Position: refs/heads/master@{#429638}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -3 lines) Patch
A third_party/WebKit/LayoutTests/fast/multicol/dynamic/remove-spanner-in-empty-nested-block-crash.html View 1 chunk +16 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
mstensho (USE GERRIT)
Before I can refactor layoutBlockFlow() in https://codereview.chromium.org/2471623003/ , I'd like to clean up some pagination ...
4 years, 1 month ago (2016-11-03 12:16:24 UTC) #6
eae
OK, LGTM
4 years, 1 month ago (2016-11-03 16:14:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2473953003/1
4 years, 1 month ago (2016-11-03 16:28:28 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-03 17:44:39 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 17:48:23 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b8a54c69086b8c5210ca896e3b6a7e924c84ae5a
Cr-Commit-Position: refs/heads/master@{#429638}

Powered by Google App Engine
This is Rietveld 408576698