Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2473903002: Updated ResetPose logic for GVR devices (Closed)

Created:
4 years, 1 month ago by bajones
Modified:
4 years, 1 month ago
Reviewers:
mthiesse
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Updated ResetPose logic for GVR devices Old call was deprecated and new one should only be used with Cardboard devices BUG=389343 Committed: https://crrev.com/ece9c5729f55509bbe9d50d2c850f328eea48fda Cr-Commit-Position: refs/heads/master@{#429480}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M device/vr/android/gvr/gvr_device.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
bajones
PTAL
4 years, 1 month ago (2016-11-02 22:49:45 UTC) #2
mthiesse
lgtm
4 years, 1 month ago (2016-11-02 23:02:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2473903002/1
4 years, 1 month ago (2016-11-02 23:47:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-03 00:38:48 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 00:43:41 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ece9c5729f55509bbe9d50d2c850f328eea48fda
Cr-Commit-Position: refs/heads/master@{#429480}

Powered by Google App Engine
This is Rietveld 408576698