Issue 24739002: Enable sending MessagePorts to a different renderer (Blink side)

Issue 24739002: Enable sending MessagePorts to a different renderer (Blink side) (Closed)

Created:
7 years, 2 months ago by marja

Modified:
7 years, 2 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
blink-reviews, jamesr, dglazkov+blink, Nate Chapin, gavinp+loader_chromium.org, abarth-chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Enable sending MessagePorts to a different renderer (Blink side). The corresponding Chromium side is: https://codereview.chromium.org/24733002/ (Tests are included in the Chromium CL.) BUG=278336 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159773

Patch Set 2 : Passing the port works now (port not yet functional) #

Patch Set 6 : The Real Fix (no proof of concept any more) #

Total comments: 2

Patch Set 7 : Code review (jochen) #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -6 lines)			Patch
M	Source/core/events/MessageEvent.h	View	1 2 3 4 5	4 chunks	+12 lines, -0 lines	0 comments	Download
M	Source/core/events/MessageEvent.cpp	View	1 2 3 4 5	2 chunks	+20 lines, -0 lines	0 comments	Download
M	Source/core/frame/DOMWindow.cpp	View	1 2 3 4 5	3 chunks	+5 lines, -4 lines	0 comments	Download
M	Source/web/WebDOMMessageEvent.cpp	View	1 2 3 4 5 6	3 chunks	+16 lines, -1 line	0 comments	Download
M	public/web/WebDOMMessageEvent.h	View	1 2 3 4 5	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

lgtm https://codereview.chromium.org/24739002/diff/20001/Source/web/WebDOMMessageEvent.cpp File Source/web/WebDOMMessageEvent.cpp (right): https://codereview.chromium.org/24739002/diff/20001/Source/web/WebDOMMessageEvent.cpp#newcode56 Source/web/WebDOMMessageEvent.cpp:56: if (webChannels.size() > 0 && sourceFrame) { nit. ...

7 years, 2 months ago (2013-10-16 00:03:20 UTC) #2

marja

Thanks for review! https://codereview.chromium.org/24739002/diff/20001/Source/web/WebDOMMessageEvent.cpp File Source/web/WebDOMMessageEvent.cpp (right): https://codereview.chromium.org/24739002/diff/20001/Source/web/WebDOMMessageEvent.cpp#newcode56 Source/web/WebDOMMessageEvent.cpp:56: if (webChannels.size() > 0 && sourceFrame) ...

7 years, 2 months ago (2013-10-16 08:19:04 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marja@chromium.org/24739002/26001

7 years, 2 months ago (2013-10-16 08:23:07 UTC) #4

Message was sent while issue was closed.

Change committed as 159773

Expand Messages | Collapse Messages