Remove MaterialDesignController::IsModeMaterial

Remove MaterialDesignController::IsModeMaterial

BUG=648281
Committed: https://crrev.com/12e0bd16fed2dc48573a525c704ec4c966691f09
Cr-Commit-Position: refs/heads/master@{#431343}

[Evan Stade, 2016-11-03 18:07:56]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 18:08:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 18:18:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 18:18:22]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[Evan Stade, 2016-11-04 03:21:54]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 03:22:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 03:29:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 03:29:07]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Evan Stade, 2016-11-07 17:35:01]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 17:35:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 17:45:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 17:45:55]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[Evan Stade, 2016-11-07 17:49:27]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[Evan Stade, 2016-11-07 17:49:39]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[Evan Stade, 2016-11-07 17:49:50]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-07 17:50:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 18:33:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 18:33:05]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Evan Stade, 2016-11-08 01:04:00]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 01:04:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 01:39:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 01:39:11]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Evan Stade, 2016-11-08 14:35:37]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 14:35:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 14:48:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 14:48:34]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Evan Stade, 2016-11-08 23:22:23]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 23:22:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 00:35:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-09 00:35:23]

Dry run: This issue passed the CQ dry run.

[Evan Stade, 2016-11-09 00:44:05]

estade@chromium.org changed reviewers:
+ pkasting@chromium.org

[Evan Stade, 2016-11-09 00:44:06]

+pkasting, mind taking a first look before I send to more OWNERS?

[Peter Kasting, 2016-11-10 05:42:20]

LGTM

https://codereview.chromium.org/2473863004/diff/140001/chrome/browser/themes/...
File chrome/browser/themes/theme_service_mac.mm (right):

https://codereview.chromium.org/2473863004/diff/140001/chrome/browser/themes/...
chrome/browser/themes/theme_service_mac.mm:55: // crbug.com/648281
It seems like it would be fairly easy to remove those traces now (from looking
at what they affect).  Can we not do so?

https://codereview.chromium.org/2473863004/diff/140001/chrome/browser/ui/view...
File chrome/browser/ui/views/frame/browser_frame.cc (right):

https://codereview.chromium.org/2473863004/diff/140001/chrome/browser/ui/view...
chrome/browser/ui/views/frame/browser_frame.cc:31: #include
"ui/native_theme/native_theme_dark_aura.h"
Nit: I'd be inclined to leave this under an "if CHROMEOS || WIN", but whatever.

https://codereview.chromium.org/2473863004/diff/140001/chrome/browser/ui/view...
chrome/browser/ui/views/frame/browser_frame.cc:186: #if defined(OS_WIN) ||
defined(OS_CHROMEOS)
Nit: This #if can now surround the entire conditional.

https://codereview.chromium.org/2473863004/diff/140001/components/infobars/co...
File components/infobars/core/infobar.cc (right):

https://codereview.chromium.org/2473863004/diff/140001/components/infobars/co...
components/infobars/core/infobar.cc:41: static const SkColor
kPageActionBackgroundColor = SK_ColorWHITE;
Nit: This one can be constexpr

(The other can't because in debug mode SkColorSetRGB() calls an assertion
function which printfs.)

[Evan Stade, 2016-11-10 15:38:31]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 15:38:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Evan Stade, 2016-11-10 15:39:46]

estade@chromium.org changed reviewers:
+ sadrul@chromium.org

[Evan Stade, 2016-11-10 15:39:47]

+sadrul, could you take a look at ui/base/material_design/?

https://codereview.chromium.org/2473863004/diff/140001/chrome/browser/themes/...
File chrome/browser/themes/theme_service_mac.mm (right):

https://codereview.chromium.org/2473863004/diff/140001/chrome/browser/themes/...
chrome/browser/themes/theme_service_mac.mm:55: // crbug.com/648281
On 2016/11/10 05:42:20, Peter Kasting wrote:
> It seems like it would be fairly easy to remove those traces now (from looking
> at what they affect).  Can we not do so?

not really, because I think properly scrubbing MD references will involve
getting rid of this kMaterialDesignIdOffset stuff (not just adding the offset
unconditionally).

https://codereview.chromium.org/2473863004/diff/140001/chrome/browser/ui/view...
File chrome/browser/ui/views/frame/browser_frame.cc (right):

https://codereview.chromium.org/2473863004/diff/140001/chrome/browser/ui/view...
chrome/browser/ui/views/frame/browser_frame.cc:31: #include
"ui/native_theme/native_theme_dark_aura.h"
On 2016/11/10 05:42:20, Peter Kasting wrote:
> Nit: I'd be inclined to leave this under an "if CHROMEOS || WIN", but
whatever.

Acknowledged.

https://codereview.chromium.org/2473863004/diff/140001/chrome/browser/ui/view...
chrome/browser/ui/views/frame/browser_frame.cc:186: #if defined(OS_WIN) ||
defined(OS_CHROMEOS)
On 2016/11/10 05:42:20, Peter Kasting wrote:
> Nit: This #if can now surround the entire conditional.

Done.

https://codereview.chromium.org/2473863004/diff/140001/components/infobars/co...
File components/infobars/core/infobar.cc (right):

https://codereview.chromium.org/2473863004/diff/140001/components/infobars/co...
components/infobars/core/infobar.cc:41: static const SkColor
kPageActionBackgroundColor = SK_ColorWHITE;
On 2016/11/10 05:42:20, Peter Kasting wrote:
> Nit: This one can be constexpr
> 
> (The other can't because in debug mode SkColorSetRGB() calls an assertion
> function which printfs.)

Done.

[commit-bot: I haz the power, 2016-11-10 16:29:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 16:29:14]

Dry run: This issue passed the CQ dry run.

[sadrul, 2016-11-10 20:39:40]

lgtm

[Evan Stade, 2016-11-10 20:39:54]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2016-11-10 20:39:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2473863004/#ps160001
(title: "pkasting review and rebase")

[commit-bot: I haz the power, 2016-11-10 20:40:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 20:46:26]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-11-10 21:00:05]

Description was changed from

==========
Remove MaterialDesignController::IsModeMaterial

BUG=648281
==========

to

==========
Remove MaterialDesignController::IsModeMaterial

BUG=648281

Committed: https://crrev.com/12e0bd16fed2dc48573a525c704ec4c966691f09
Cr-Commit-Position: refs/heads/master@{#431343}
==========

[commit-bot: I haz the power, 2016-11-10 21:00:06]

Patchset 9 (id:??) landed as
https://crrev.com/12e0bd16fed2dc48573a525c704ec4c966691f09
Cr-Commit-Position: refs/heads/master@{#431343}