Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2473863003:
Fix BiDi directionality for surrogate pair characters (Closed)
|
Created:
4 years, 1 month ago by kojii Modified:
4 years, 1 month ago Reviewers:
eae CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1 Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix BiDi directionality for surrogate pair characters
This patch fixes BiDi directionality for non-BMP (surrogate pair)
characters.
LayoutText::codepointAt was changed to use ICU U16_GET function that
can compute even when the index is at the mid of a surrogate pair.
Rebaseline incorrect expected for svg/text/surrogate-pair-queries.html
BUG=488904
Committed: https://crrev.com/ea599b0be3e912060db3a4a2b3bf2510c114775c
Cr-Commit-Position: refs/heads/master@{#429790}
Patch Set 1 #Patch Set 2 : Align index check behavior of codepointAt to characterAt #Patch Set 3 : Rebaseline svg/text/surrogate-pair-queries.html #
Total comments: 2
Patch Set 4 : eae review: add </td> and </tr> to tests #
Messages
Total messages: 33 (27 generated)
The CQ bit was checked by kojii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
Description was changed from ========== rtl-surrogate-pair BUG= ========== to ========== Fix BiDi directionality for surrogate pair characters This patch fixes BiDi directionality for non-BMP (surrogate pair) characters. LayoutText::codepointAt was changed to use ICU U16_GET function that can compute even when the index is at the mid of a surrogate pair. Ideally InlineIterator should iterate code points. This patch does not fix this, and relies on U16_GET behavior mentioned above. BUG=488904 ==========
The CQ bit was checked by kojii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Fix BiDi directionality for surrogate pair characters This patch fixes BiDi directionality for non-BMP (surrogate pair) characters. LayoutText::codepointAt was changed to use ICU U16_GET function that can compute even when the index is at the mid of a surrogate pair. Ideally InlineIterator should iterate code points. This patch does not fix this, and relies on U16_GET behavior mentioned above. BUG=488904 ========== to ========== Fix BiDi directionality for surrogate pair characters This patch fixes BiDi directionality for non-BMP (surrogate pair) characters. LayoutText::codepointAt was changed to use ICU U16_GET function that can compute even when the index is at the mid of a surrogate pair. This patch does not fix InlineIterator to iterate code points, but relies on U16_GET behavior mentioned above. BUG=488904 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by kojii@chromium.org to run a CQ dry run
Description was changed from ========== Fix BiDi directionality for surrogate pair characters This patch fixes BiDi directionality for non-BMP (surrogate pair) characters. LayoutText::codepointAt was changed to use ICU U16_GET function that can compute even when the index is at the mid of a surrogate pair. This patch does not fix InlineIterator to iterate code points, but relies on U16_GET behavior mentioned above. BUG=488904 ========== to ========== Fix BiDi directionality for surrogate pair characters This patch fixes BiDi directionality for non-BMP (surrogate pair) characters. LayoutText::codepointAt was changed to use ICU U16_GET function that can compute even when the index is at the mid of a surrogate pair. This patch does not fix InlineIterator to iterate code points, but relies on U16_GET behavior mentioned above. Rebaseline incorrect expected for svg/text/surrogate-pair-queries.html BUG=488904 ==========
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by kojii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #3 (id:40001) has been deleted
kojii@chromium.org changed reviewers: + eae@chromium.org
PTAL.
Description was changed from ========== Fix BiDi directionality for surrogate pair characters This patch fixes BiDi directionality for non-BMP (surrogate pair) characters. LayoutText::codepointAt was changed to use ICU U16_GET function that can compute even when the index is at the mid of a surrogate pair. This patch does not fix InlineIterator to iterate code points, but relies on U16_GET behavior mentioned above. Rebaseline incorrect expected for svg/text/surrogate-pair-queries.html BUG=488904 ========== to ========== Fix BiDi directionality for surrogate pair characters This patch fixes BiDi directionality for non-BMP (surrogate pair) characters. LayoutText::codepointAt was changed to use ICU U16_GET function that can compute even when the index is at the mid of a surrogate pair. Rebaseline incorrect expected for svg/text/surrogate-pair-queries.html BUG=488904 ==========
LGTM https://codereview.chromium.org/2473863003/diff/60001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/fast/text/international/bidi-surrogate-pair.html (right): https://codereview.chromium.org/2473863003/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/fast/text/international/bidi-surrogate-pair.html:5: <td>Avestan You might want to close the <td> and <tr> tags...
The CQ bit was checked by kojii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by kojii@chromium.org
Thank you for prompt review as always. https://codereview.chromium.org/2473863003/diff/60001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/fast/text/international/bidi-surrogate-pair.html (right): https://codereview.chromium.org/2473863003/diff/60001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/fast/text/international/bidi-surrogate-pair.html:5: <td>Avestan On 2016/11/03 at 16:01:10, eae wrote: > You might want to close the <td> and <tr> tags... Done.
The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org Link to the patchset: https://codereview.chromium.org/2473863003/#ps80001 (title: "eae review: add </td> and </tr> to tests")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #4 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== Fix BiDi directionality for surrogate pair characters This patch fixes BiDi directionality for non-BMP (surrogate pair) characters. LayoutText::codepointAt was changed to use ICU U16_GET function that can compute even when the index is at the mid of a surrogate pair. Rebaseline incorrect expected for svg/text/surrogate-pair-queries.html BUG=488904 ========== to ========== Fix BiDi directionality for surrogate pair characters This patch fixes BiDi directionality for non-BMP (surrogate pair) characters. LayoutText::codepointAt was changed to use ICU U16_GET function that can compute even when the index is at the mid of a surrogate pair. Rebaseline incorrect expected for svg/text/surrogate-pair-queries.html BUG=488904 Committed: https://crrev.com/ea599b0be3e912060db3a4a2b3bf2510c114775c Cr-Commit-Position: refs/heads/master@{#429790} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/ea599b0be3e912060db3a4a2b3bf2510c114775c Cr-Commit-Position: refs/heads/master@{#429790} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
