Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2473833004:
Fix bug: "WebAPKs don't get past splash screen with release Chrome". (Closed)
DescriptionFix bug: "WebAPKs don't get past splash screen with release Chrome".
When creating WebApkSandboxedProcessService, we use reflection to call
ChildProcessServiceImpl#create() and ChildProcessServiceImpl#bind(). Add
"@UsedByReflection" flag to the class and the methods to prevent from
being removed by Proguard in release build.
BUG=661407
Committed: https://crrev.com/17efc52ce3bb93c96b162ef9fd697233839a7a84
Cr-Commit-Position: refs/heads/master@{#429667}
Patch Set 1 #Patch Set 2 : Rebase #Messages
Total messages: 21 (14 generated)
Description was changed from ========== Fix:WebAPKs don't get past splash screen with release Chrome. When creating WebApkSandboxedProcessService, we use reflection to call ChildProcessServiceImpl#create() and ChildProcessServiceImpl#bind(). Add "@UsedByReflection" flag to the class and the methods to prevent from being removed by Proguard in release build. BUG=661407 ========== to ========== Fix bug: "WebAPKs don't get past splash screen with release Chrome". When creating WebApkSandboxedProcessService, we use reflection to call ChildProcessServiceImpl#create() and ChildProcessServiceImpl#bind(). Add "@UsedByReflection" flag to the class and the methods to prevent from being removed by Proguard in release build. BUG=661407 ==========
hanxi@chromium.org changed reviewers: + agrieve@chromium.org
Hi Andrew, could you please take a look? Thanks!
The CQ bit was checked by hanxi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
lgtm
hanxi@chromium.org changed reviewers: + tedchoc@chromium.org
Hi Ted, I need OWNERS review, could you please take a look? Thanks!
The CQ bit was checked by hanxi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/11/03 18:02:38, Xi Han wrote: > Hi Ted, I need OWNERS review, could you please take a look? Thanks! lgtm
The CQ bit was unchecked by hanxi@chromium.org
The CQ bit was checked by hanxi@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from agrieve@chromium.org Link to the patchset: https://codereview.chromium.org/2473833004/#ps20001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix bug: "WebAPKs don't get past splash screen with release Chrome". When creating WebApkSandboxedProcessService, we use reflection to call ChildProcessServiceImpl#create() and ChildProcessServiceImpl#bind(). Add "@UsedByReflection" flag to the class and the methods to prevent from being removed by Proguard in release build. BUG=661407 ========== to ========== Fix bug: "WebAPKs don't get past splash screen with release Chrome". When creating WebApkSandboxedProcessService, we use reflection to call ChildProcessServiceImpl#create() and ChildProcessServiceImpl#bind(). Add "@UsedByReflection" flag to the class and the methods to prevent from being removed by Proguard in release build. BUG=661407 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Fix bug: "WebAPKs don't get past splash screen with release Chrome". When creating WebApkSandboxedProcessService, we use reflection to call ChildProcessServiceImpl#create() and ChildProcessServiceImpl#bind(). Add "@UsedByReflection" flag to the class and the methods to prevent from being removed by Proguard in release build. BUG=661407 ========== to ========== Fix bug: "WebAPKs don't get past splash screen with release Chrome". When creating WebApkSandboxedProcessService, we use reflection to call ChildProcessServiceImpl#create() and ChildProcessServiceImpl#bind(). Add "@UsedByReflection" flag to the class and the methods to prevent from being removed by Proguard in release build. BUG=661407 Committed: https://crrev.com/17efc52ce3bb93c96b162ef9fd697233839a7a84 Cr-Commit-Position: refs/heads/master@{#429667} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/17efc52ce3bb93c96b162ef9fd697233839a7a84 Cr-Commit-Position: refs/heads/master@{#429667} |
