Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1669)

Unified Diff: chrome/browser/chromeos/policy/heartbeat_scheduler_unittest.cc

Issue 2473813002: Notify GCMAppHandlers when the store is reset, so they clear cached IDs (Closed)
Patch Set: HeartbeatScheduler to call and test RefreshHeartbeatSettings Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/policy/heartbeat_scheduler_unittest.cc
diff --git a/chrome/browser/chromeos/policy/heartbeat_scheduler_unittest.cc b/chrome/browser/chromeos/policy/heartbeat_scheduler_unittest.cc
index bcbc123aaa16a106199d5f0ffa93d0f8be3c4b6f..8d3946c4b5b0c45d04dd310c2a7ae064ead9f507 100644
--- a/chrome/browser/chromeos/policy/heartbeat_scheduler_unittest.cc
+++ b/chrome/browser/chromeos/policy/heartbeat_scheduler_unittest.cc
@@ -100,6 +100,11 @@ class MockGCMDriver : public testing::StrictMock<gcm::FakeGCMDriver> {
.Times(AnyNumber());
}
+ void ResetStore() {
+ for (const auto& key_value : app_handlers())
+ key_value.second->OnStoreReset();
+ }
+
private:
gcm::GCMConnectionObserver* observer_ = nullptr;
@@ -210,6 +215,58 @@ TEST_F(HeartbeatSchedulerTest, TemporarilyFailedGCMRegistration) {
task_runner_->RunPendingTasks();
}
+TEST_F(HeartbeatSchedulerTest, StoreResetDuringRegistration) {
+ IgnoreUpstreamNotificationMsg();
+
+ EXPECT_CALL(gcm_driver_, RegisterImpl(kHeartbeatGCMAppID, _));
+ settings_helper_.SetBoolean(chromeos::kHeartbeatEnabled, true);
+
+ gcm_driver_.ResetStore();
+
+ // Successful registration handled ok despite store reset.
+ EXPECT_CALL(gcm_driver_, SendImpl(kHeartbeatGCMAppID, _, IsHeartbeatMsg()));
+ gcm_driver_.CompleteRegistration(
+ kHeartbeatGCMAppID, gcm::GCMClient::SUCCESS);
+ EXPECT_EQ(1U, task_runner_->NumPendingTasks());
+ task_runner_->RunPendingTasks();
+ testing::Mock::VerifyAndClearExpectations(&gcm_driver_);
+}
+
+TEST_F(HeartbeatSchedulerTest, StoreResetAfterRegistration) {
+ IgnoreUpstreamNotificationMsg();
+
+ // Start from a successful registration.
+ EXPECT_CALL(gcm_driver_, RegisterImpl(kHeartbeatGCMAppID, _));
+ settings_helper_.SetBoolean(chromeos::kHeartbeatEnabled, true);
+ EXPECT_CALL(gcm_driver_, SendImpl(kHeartbeatGCMAppID, _, IsHeartbeatMsg()));
+ gcm_driver_.CompleteRegistration(
+ kHeartbeatGCMAppID, gcm::GCMClient::SUCCESS);
+ EXPECT_EQ(1U, task_runner_->NumPendingTasks());
+ task_runner_->RunPendingTasks();
+ testing::Mock::VerifyAndClearExpectations(&gcm_driver_);
+
+ IgnoreUpstreamNotificationMsg();
+ gcm_driver_.IgnoreDefaultHeartbeatsInterval();
+
+ // Since registration succeeded, no need for a pending task.
+ EXPECT_FALSE(task_runner_->HasPendingTask());
+
+ // Reseting the store should trigger re-registration.
+ gcm_driver_.ResetStore();
+ EXPECT_EQ(1U, task_runner_->NumPendingTasks());
+ EXPECT_CALL(gcm_driver_, RegisterImpl(kHeartbeatGCMAppID, _));
+ task_runner_->RunPendingTasks();
+ testing::Mock::VerifyAndClearExpectations(&gcm_driver_);
+
+ // Once we have successfully re-registered, we should send a heartbeat.
+ EXPECT_CALL(gcm_driver_, SendImpl(kHeartbeatGCMAppID, _, IsHeartbeatMsg()));
+ gcm_driver_.CompleteRegistration(
+ kHeartbeatGCMAppID, gcm::GCMClient::SUCCESS);
+ EXPECT_EQ(1U, task_runner_->NumPendingTasks());
+ task_runner_->RunPendingTasks();
+ testing::Mock::VerifyAndClearExpectations(&gcm_driver_);
+}
+
TEST_F(HeartbeatSchedulerTest, ChangeHeartbeatFrequency) {
IgnoreUpstreamNotificationMsg();

Powered by Google App Engine
This is Rietveld 408576698