Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Unified Diff: components/invalidation/impl/gcm_invalidation_bridge.cc

Issue 2473813002: Notify GCMAppHandlers when the store is reset, so they clear cached IDs (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/invalidation/impl/gcm_invalidation_bridge.cc
diff --git a/components/invalidation/impl/gcm_invalidation_bridge.cc b/components/invalidation/impl/gcm_invalidation_bridge.cc
index 09aca1e3991a2ec7e6b8a5ab57de62f236d9a7b1..0d641712ef7655303dc332b18fbb8f7cecdc8707 100644
--- a/components/invalidation/impl/gcm_invalidation_bridge.cc
+++ b/components/invalidation/impl/gcm_invalidation_bridge.cc
@@ -319,6 +319,11 @@ void GCMInvalidationBridge::ShutdownHandler() {
// Nothing to do.
}
+void GCMInvalidationBridge::OnStoreReset() {
+ // Nothing to do here since CacheInvalidation doesn't locally persist
+ // registration ID, instead it just re-registers on every startup.
Peter Beverloo 2016/11/03 17:28:57 What about GCMNetworkChannel::registration_id_?
johnme 2016/11/08 19:22:41 Done - this was a little more involved, as I had t
+}
+
void GCMInvalidationBridge::OnMessage(const std::string& app_id,
const gcm::IncomingMessage& message) {
gcm::MessageData::const_iterator it;

Powered by Google App Engine
This is Rietveld 408576698