Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 2473783004: [android] Raise an exception when an instr test filter doesn't match a test. (Closed)

Created:
4 years, 1 month ago by jbudorick
Modified:
4 years, 1 month ago
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[android] Raise an exception when an instr test filter doesn't match a test. BUG=662018 Committed: https://crrev.com/ab83a4681077621ced18c53dc6f3cd21d0d319e1 Cr-Commit-Position: refs/heads/master@{#430763}

Patch Set 1 #

Patch Set 2 : --no-find-copies #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -2 lines) Patch
A build/android/pylib/base/test_exception.py View 1 1 chunk +9 lines, -0 lines 0 comments Download
M build/android/pylib/instrumentation/instrumentation_test_instance.py View 4 chunks +13 lines, -2 lines 0 comments Download
M build/android/test_runner.pydeps View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
jbudorick
4 years, 1 month ago (2016-11-03 18:23:13 UTC) #2
BigBossZhiling
lgtm
4 years, 1 month ago (2016-11-03 20:27:54 UTC) #3
jbudorick
+rnephew for committer
4 years, 1 month ago (2016-11-03 20:28:41 UTC) #5
rnephew (Reviews Here)
On 2016/11/03 20:28:41, jbudorick wrote: > +rnephew for committer lgtm
4 years, 1 month ago (2016-11-03 20:30:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2473783004/20001
4 years, 1 month ago (2016-11-03 20:31:25 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/330512)
4 years, 1 month ago (2016-11-03 22:08:25 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2473783004/40001
4 years, 1 month ago (2016-11-08 20:38:35 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-08 23:40:10 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 23:45:32 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ab83a4681077621ced18c53dc6f3cd21d0d319e1
Cr-Commit-Position: refs/heads/master@{#430763}

Powered by Google App Engine
This is Rietveld 408576698