third_party/WebKit/Source/core/dom/stylerecalc.md - Issue 2473743003: Call Element::rebuildLayoutTree from Document::updateStyle directly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/stylerecalc.md

Issue 2473743003: Call Element::rebuildLayoutTree from Document::updateStyle directly (Closed)

Patch Set: Make needsAttach() only check if getStyleChangeType flag is NeedsReattachStyleChange and add a Layo… Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp ('k') | third_party/WebKit/Source/core/html/HTMLFrameSetElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/stylerecalc.md

diff --git a/third_party/WebKit/Source/core/dom/stylerecalc.md b/third_party/WebKit/Source/core/dom/stylerecalc.md

index aacc22fce5f4ebfc8a2b05d2101efba25c227975..468713ffd8cd5764b063ae5d5e7cf86df5fd69e1 100644

--- a/third_party/WebKit/Source/core/dom/stylerecalc.md

+++ b/third_party/WebKit/Source/core/dom/stylerecalc.md

@@ -12,5 +12,4 @@ The states are as follows:

4. IndependentInherit -> Same as Inherit except style recalc stops early if only independent properties were changed. We still visit every descendant, but we apply the styles directly instead of doing selector matching to compute a new style. Independent properties are those which do not depend on and do not affect any other properties on ComputedStyle (e.g. visibility and Pointer Events).

5. Inherit -> Do a full style recalc of children.

6. Force -> Fallback that causes us to do a full style recalc. This is as we don't know what changes. The primary reason for it is SubtreeStyleChange.

-7. Reattach -> reattachLayoutTree() has been completed.

-8. ReattachNoLayoutObject -> reattachLayoutTree() has been completed and now dont have a layoutObject.

+7. Reattach -> reattachLayoutTree() needs to be performed.