Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Unified Diff: third_party/WebKit/Source/core/dom/Node.h

Issue 2473743003: Call Element::rebuildLayoutTree from Document::updateStyle directly (Closed)
Patch Set: Make needsAttach() only check if getStyleChangeType flag is NeedsReattachStyleChange and add a Layo… Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/dom/Element.cpp ('k') | third_party/WebKit/Source/core/dom/Node.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/Node.h
diff --git a/third_party/WebKit/Source/core/dom/Node.h b/third_party/WebKit/Source/core/dom/Node.h
index 63b03b0e72c7376796755b27a995dab40d6ba065..96331dd9bf230de7d808ce4aaaef39aed2019d76 100644
--- a/third_party/WebKit/Source/core/dom/Node.h
+++ b/third_party/WebKit/Source/core/dom/Node.h
@@ -830,7 +830,9 @@ class CORE_EXPORT Node : public EventTarget {
NeedsReattachLayoutTree = 1 << 26,
ChildNeedsReattachLayoutTree = 1 << 27,
- DefaultNodeFlags = IsFinishedParsingChildrenFlag | NeedsReattachStyleChange
+ DefaultNodeFlags = IsFinishedParsingChildrenFlag |
+ NeedsReattachStyleChange |
+ NeedsReattachLayoutTree
};
// 4 bits remaining.
@@ -853,8 +855,9 @@ class CORE_EXPORT Node : public EventTarget {
enum ConstructionType {
CreateOther = DefaultNodeFlags,
CreateText = DefaultNodeFlags | IsTextFlag,
- CreateContainer =
- DefaultNodeFlags | ChildNeedsStyleRecalcFlag | IsContainerFlag,
+ CreateContainer = DefaultNodeFlags | ChildNeedsStyleRecalcFlag |
+ ChildNeedsReattachLayoutTree |
+ IsContainerFlag,
CreateElement = CreateContainer | IsElementFlag,
CreateShadowRoot =
CreateContainer | IsDocumentFragmentFlag | IsInShadowTreeFlag,
@@ -974,6 +977,7 @@ inline void Node::lazyReattachIfAttached() {
detachLayoutTree(context);
markAncestorsWithChildNeedsStyleRecalc();
+ markAncestorsWithChildNeedsReattachLayoutTree();
}
inline bool Node::shouldCallRecalcStyle(StyleRecalcChange change) {
« no previous file with comments | « third_party/WebKit/Source/core/dom/Element.cpp ('k') | third_party/WebKit/Source/core/dom/Node.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698