Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp

Issue 2473743003: Call Element::rebuildLayoutTree from Document::updateStyle directly (Closed)
Patch Set: Clean up all the asserts Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp
diff --git a/third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp b/third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp
index e29035dc3be460bdb1f41826b77722664ae310a0..5c4e891dbb32a235949d9a39a40c4e09b25971f3 100644
--- a/third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp
+++ b/third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp
@@ -82,10 +82,10 @@ ShadowRoot& ElementShadow::addShadowRoot(Element& shadowHost,
setNeedsDistributionRecalc();
shadowRoot->insertedInto(&shadowHost);
- shadowHost.setChildNeedsStyleRecalc();
esprehn 2017/02/16 21:24:33 I think we probably want to leave this, while tech
nainar 2017/02/16 22:26:09 Sure :)
shadowHost.setNeedsStyleRecalc(
SubtreeStyleChange,
StyleChangeReasonForTracing::create(StyleChangeReason::Shadow));
+ shadowRoot->setNeedsReattachLayoutTree();
InspectorInstrumentation::didPushShadowRoot(&shadowHost, shadowRoot);

Powered by Google App Engine
This is Rietveld 408576698