third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp - Issue 2473743003: Call Element::rebuildLayoutTree from Document::updateStyle directly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp

Issue 2473743003: Call Element::rebuildLayoutTree from Document::updateStyle directly (Closed)

Patch Set: Fix unconditional ShadowRoot::rebuildLayoutTree() and retain needsStyleRecalc information for cases… Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp

diff --git a/third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp b/third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp

index e29035dc3be460bdb1f41826b77722664ae310a0..5c4e891dbb32a235949d9a39a40c4e09b25971f3 100644

--- a/third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp

+++ b/third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp

@@ -82,10 +82,10 @@ ShadowRoot& ElementShadow::addShadowRoot(Element& shadowHost,

setNeedsDistributionRecalc();

shadowRoot->insertedInto(&shadowHost);

- shadowHost.setChildNeedsStyleRecalc();

shadowHost.setNeedsStyleRecalc(

SubtreeStyleChange,

StyleChangeReasonForTracing::create(StyleChangeReason::Shadow));

+ shadowRoot->setNeedsReattachLayoutTree();

InspectorInstrumentation::didPushShadowRoot(&shadowHost, shadowRoot);