third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp - Issue 2473743003: Call Element::rebuildLayoutTree from Document::updateStyle directly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp

Issue 2473743003: Call Element::rebuildLayoutTree from Document::updateStyle directly (Closed)

Patch Set: Fix failures due to information not being retained correctly for detachLayoutTree() in Text::reatta… Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp

diff --git a/third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp b/third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp

index e29035dc3be460bdb1f41826b77722664ae310a0..8297d73538cdf1165e98d744e692a7d778c8e792 100644

--- a/third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp

+++ b/third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp

@@ -83,6 +83,7 @@ ShadowRoot& ElementShadow::addShadowRoot(Element& shadowHost,

shadowRoot->insertedInto(&shadowHost);

shadowHost.setChildNeedsStyleRecalc();

esprehn 2017/02/13 22:19:41 remove this line it doesn't do anything since we d

nainar 2017/02/14 03:42:09 Done.

+ shadowHost.setChildNeedsReattachLayoutTree();

esprehn 2017/02/13 22:19:41 you can remove this one.

nainar 2017/02/14 03:42:09 Done.

shadowHost.setNeedsStyleRecalc(

SubtreeStyleChange,

StyleChangeReasonForTracing::create(StyleChangeReason::Shadow));