third_party/WebKit/Source/core/dom/Document.cpp - Issue 2473743003: Call Element::rebuildLayoutTree from Document::updateStyle directly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 2473743003: Call Element::rebuildLayoutTree from Document::updateStyle directly (Closed)

Patch Set: Split up didRecalcStyle into didRecalcStyle and didRebuildLayoutTree Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Document.cpp

diff --git a/third_party/WebKit/Source/core/dom/Document.cpp b/third_party/WebKit/Source/core/dom/Document.cpp

index d0f32230eb9d19460f541d37edbe76016e63dfc1..c6967d94032f82c0d2781f7ddf0d2e946ceaae88 100644

--- a/third_party/WebKit/Source/core/dom/Document.cpp

+++ b/third_party/WebKit/Source/core/dom/Document.cpp

@@ -2052,6 +2052,10 @@ void Document::updateStyle() {

inheritHtmlAndBodyElementStyles(change);

if (documentElement->shouldCallRecalcStyle(change))

documentElement->recalcStyle(change);

+ DCHECK(!documentElement->needsStyleRecalc());

+ if (documentElement->needsReattachLayoutTree() ||

+ documentElement->childNeedsReattachLayoutTree())

+ documentElement->rebuildLayoutTree();

}

view()->recalcOverflowAfterStyleChange();