Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp

Issue 2473743003: Call Element::rebuildLayoutTree from Document::updateStyle directly (Closed)
Patch Set: Handover Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp
diff --git a/third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp b/third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp
index 835e03e3aaaba6149be358deb6f62dd29e959dca..5e92c9329656a7da9dcd9e63411af6ea56827d3e 100644
--- a/third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp
+++ b/third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp
@@ -129,10 +129,19 @@ void ShadowRoot::recalcStyle(StyleRecalcChange change) {
// There's no style to update so just calling recalcStyle means we're updated.
clearNeedsStyleRecalc();
- clearNeedsReattachLayoutTree();
recalcDescendantStyles(change);
clearChildNeedsStyleRecalc();
+ setNeedsReattachLayoutTree();
+}
+
+void ShadowRoot::rebuildLayoutTree() {
+ DCHECK(!needsStyleRecalc());
+ // ShadowRoot doesn't support custom callbacks.
+ DCHECK(!hasCustomStyleCallbacks());
+
+ clearNeedsReattachLayoutTree();
+ rebuildChildrenLayoutTrees();
clearChildNeedsReattachLayoutTree();
}

Powered by Google App Engine
This is Rietveld 408576698