Index: third_party/WebKit/Source/core/dom/Element.cpp |
diff --git a/third_party/WebKit/Source/core/dom/Element.cpp b/third_party/WebKit/Source/core/dom/Element.cpp |
index 7c286936357b055b17ba342c2581c8daf2be69cc..ac57a0c1c340046df5a8cb3220f057a3bea1a484 100644 |
--- a/third_party/WebKit/Source/core/dom/Element.cpp |
+++ b/third_party/WebKit/Source/core/dom/Element.cpp |
@@ -1855,10 +1855,15 @@ void Element::recalcStyle(StyleRecalcChange change, Text* nextTextSibling) { |
elementAnimations->setAnimationStyleChange(false); |
} |
} |
- if (parentComputedStyle()) |
+ if (parentComputedStyle()) { |
change = recalcOwnStyle(change, nextTextSibling); |
+ } else { |
+ // In case we don't perform recalcOwnStyle we will never clear the |
+ // NeedsReattachLayoutTree flag which is set on the creation of each |
+ // Node. Clear that here. |
+ clearNeedsReattachLayoutTree(); |
+ } |
clearNeedsStyleRecalc(); |
- clearNeedsReattachLayoutTree(); |
} |
// If we reattached we don't need to recalc the style of our descendants |
@@ -1890,7 +1895,6 @@ void Element::recalcStyle(StyleRecalcChange change, Text* nextTextSibling) { |
childNeedsStyleRecalc() ? Force : change); |
clearChildNeedsStyleRecalc(); |
- clearChildNeedsReattachLayoutTree(); |
} |
if (hasCustomStyleCallbacks()) |
@@ -1950,7 +1954,7 @@ StyleRecalcChange Element::recalcOwnStyle(StyleRecalcChange change, |
styleReattachData.nextTextSibling = nextTextSibling; |
document().addStyleReattachData(*this, styleReattachData); |
setNeedsReattachLayoutTree(); |
- return rebuildLayoutTree(); |
+ return Reattach; |
} |
DCHECK(oldStyle); |
@@ -1991,23 +1995,30 @@ StyleRecalcChange Element::recalcOwnStyle(StyleRecalcChange change, |
return localChange; |
} |
-StyleRecalcChange Element::rebuildLayoutTree() { |
+void Element::rebuildLayoutTree() { |
DCHECK(inActiveDocument()); |
+ DCHECK(!needsStyleRecalc()); |
+ DCHECK(!childNeedsStyleRecalc()); |
esprehn
2016/12/14 04:30:47
Yeah so you assert !childNeedsStyleRecalc here so
nainar
2016/12/14 22:21:54
ACK.
|
+ DCHECK(parentNode()); |
+ |
StyleReattachData styleReattachData = document().getStyleReattachData(*this); |
AttachContext reattachContext; |
reattachContext.resolvedStyle = styleReattachData.computedStyle.get(); |
bool layoutObjectWillChange = needsAttach() || layoutObject(); |
- // We are calling Element::rebuildLayoutTree() from inside |
- // Element::recalcOwnStyle where we set the NeedsReattachLayoutTree |
- // flag - so needsReattachLayoutTree() should always be true. |
- DCHECK(parentNode()); |
- DCHECK(parentNode()->childNeedsReattachLayoutTree()); |
- DCHECK(needsReattachLayoutTree()); |
- reattachLayoutTree(reattachContext); |
- // Since needsReattachLayoutTree() is always true we go into |
- // reattachLayoutTree() which reattaches all the descendant |
- // sub-trees. At this point no child should need reattaching. |
+ if (needsReattachLayoutTree()) { |
+ reattachLayoutTree(reattachContext); |
+ } else if (childNeedsReattachLayoutTree()) { |
+ SelectorFilterParentScope filterScope(*this); |
+ StyleSharingDepthScope sharingScope(*this); |
+ reattachPseudoElementLayoutTree(PseudoIdBefore); |
+ rebuildShadowRootLayoutTree(); |
+ rebuildChildrenLayoutTrees(); |
+ reattachPseudoElementLayoutTree(PseudoIdAfter); |
+ reattachPseudoElementLayoutTree(PseudoIdBackdrop); |
+ reattachPseudoElementLayoutTree(PseudoIdFirstLetter); |
+ } |
+ DCHECK(!needsReattachLayoutTree()); |
DCHECK(!childNeedsReattachLayoutTree()); |
if (layoutObjectWillChange || layoutObject()) { |
@@ -2016,9 +2027,31 @@ StyleRecalcChange Element::rebuildLayoutTree() { |
// or store it. |
// The choice is between increased time and increased memory complexity. |
reattachWhitespaceSiblingsIfNeeded(styleReattachData.nextTextSibling); |
- return Reattach; |
} |
- return ReattachNoLayoutObject; |
+} |
+ |
+void Element::rebuildShadowRootLayoutTree() { |
+ DCHECK(!needsStyleRecalc()); |
+ DCHECK(!childNeedsStyleRecalc()); |
+ DCHECK(!needsReattachLayoutTree()); |
+ for (ShadowRoot* root = youngestShadowRoot(); root; |
+ root = root->olderShadowRoot()) { |
+ if (root->needsReattachLayoutTree() || root->childNeedsReattachLayoutTree()) |
+ root->rebuildLayoutTree(); |
+ } |
+} |
+ |
+void Element::reattachPseudoElementLayoutTree(PseudoId pseudoId) { |
+ DCHECK(!needsStyleRecalc()); |
+ DCHECK(!childNeedsStyleRecalc()); |
+ DCHECK(!needsReattachLayoutTree()); |
+ if (PseudoElement* element = pseudoElement(pseudoId)) { |
+ if (element->needsReattachLayoutTree() || |
+ element->childNeedsReattachLayoutTree()) |
+ element->rebuildLayoutTree(); |
+ } else { |
+ createPseudoElementIfNeeded(pseudoId); |
+ } |
} |
void Element::updateCallbackSelectors(const ComputedStyle* oldStyle, |