Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 2473743003: Call Element::rebuildLayoutTree from Document::updateStyle directly (Closed)
Patch Set: Handover Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All
7 * rights reserved. 7 * rights reserved.
8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. 8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved.
9 * (http://www.torchmobile.com/) 9 * (http://www.torchmobile.com/)
10 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved. 10 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
(...skipping 2028 matching lines...) Expand 10 before | Expand all | Expand 10 after
2039 StyleResolver& resolver = ensureStyleResolver(); 2039 StyleResolver& resolver = ensureStyleResolver();
2040 2040
2041 bool shouldRecordStats; 2041 bool shouldRecordStats;
2042 TRACE_EVENT_CATEGORY_GROUP_ENABLED("blink,blink_style", &shouldRecordStats); 2042 TRACE_EVENT_CATEGORY_GROUP_ENABLED("blink,blink_style", &shouldRecordStats);
2043 styleEngine().setStatsEnabled(shouldRecordStats); 2043 styleEngine().setStatsEnabled(shouldRecordStats);
2044 2044
2045 if (Element* documentElement = this->documentElement()) { 2045 if (Element* documentElement = this->documentElement()) {
2046 inheritHtmlAndBodyElementStyles(change); 2046 inheritHtmlAndBodyElementStyles(change);
2047 if (documentElement->shouldCallRecalcStyle(change)) 2047 if (documentElement->shouldCallRecalcStyle(change))
2048 documentElement->recalcStyle(change); 2048 documentElement->recalcStyle(change);
2049 DCHECK(!documentElement->needsStyleRecalc());
2050 DCHECK(!documentElement->childNeedsStyleRecalc());
2051 if (documentElement->needsReattachLayoutTree() ||
2052 documentElement->childNeedsReattachLayoutTree())
2053 documentElement->rebuildLayoutTree();
2049 } 2054 }
2050 2055
2051 view()->recalcOverflowAfterStyleChange(); 2056 view()->recalcOverflowAfterStyleChange();
2052 2057
2053 // Only retain the HashMap for the duration of StyleRecalc and 2058 // Only retain the HashMap for the duration of StyleRecalc and
2054 // LayoutTreeConstruction. 2059 // LayoutTreeConstruction.
2055 m_styleReattachDataMap.clear(); 2060 m_styleReattachDataMap.clear();
2056 clearChildNeedsStyleRecalc(); 2061 clearChildNeedsStyleRecalc();
2057 clearChildNeedsReattachLayoutTree(); 2062 clearChildNeedsReattachLayoutTree();
2058 2063
(...skipping 4513 matching lines...) Expand 10 before | Expand all | Expand 10 after
6572 } 6577 }
6573 6578
6574 void showLiveDocumentInstances() { 6579 void showLiveDocumentInstances() {
6575 WeakDocumentSet& set = liveDocumentSet(); 6580 WeakDocumentSet& set = liveDocumentSet();
6576 fprintf(stderr, "There are %u documents currently alive:\n", set.size()); 6581 fprintf(stderr, "There are %u documents currently alive:\n", set.size());
6577 for (Document* document : set) 6582 for (Document* document : set)
6578 fprintf(stderr, "- Document %p URL: %s\n", document, 6583 fprintf(stderr, "- Document %p URL: %s\n", document,
6579 document->url().getString().utf8().data()); 6584 document->url().getString().utf8().data());
6580 } 6585 }
6581 #endif 6586 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698