third_party/WebKit/Source/core/dom/StyleReattachData.h - Issue 2473743003: Call Element::rebuildLayoutTree from Document::updateStyle directly

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/dom/StyleReattachData.h

Issue 2473743003: Call Element::rebuildLayoutTree from Document::updateStyle directly (Closed)

Patch Set: Address esprehn's comments Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef StyleReattachData_h	5 #ifndef StyleReattachData_h

6 #define StyleReattachData_h	6 #define StyleReattachData_h

7	7

	8 #include "core/style/ComputedStyle.h"

	9

8 namespace blink {	10 namespace blink {

9	11

10 struct StyleReattachData {	12 struct StyleReattachData {

	13 StyleReattachData() : computedStyle(nullptr) {}
	esprehn 2016/12/14 04:30:48 RefPtr actually defaults to nullptr, no reason to RefPtr actually defaults to nullptr, no reason to assign this. nainar 2016/12/14 22:21:54 Done. Done.
11 DISALLOW_NEW_EXCEPT_PLACEMENT_NEW();	14 DISALLOW_NEW_EXCEPT_PLACEMENT_NEW();

12 DEFINE_INLINE_TRACE() { visitor->trace(nextTextSibling); }	15 DEFINE_INLINE_TRACE() { visitor->trace(nextTextSibling); }

13	16

14 RefPtr<ComputedStyle> computedStyle;	17 RefPtr<ComputedStyle> computedStyle;

15 Member<Text> nextTextSibling;	18 Member<Text> nextTextSibling;

16 };	19 };

17	20

18 } // namespace blink	21 } // namespace blink

19	22

20 #endif // StyleReattachData_h	23 #endif // StyleReattachData_h

OLD	NEW