Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Side by Side Diff: third_party/WebKit/Source/core/dom/Text.cpp

Issue 2473743003: Call Element::rebuildLayoutTree from Document::updateStyle directly (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights 4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights
5 * reserved. 5 * reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 377 matching lines...) Expand 10 before | Expand all | Expand 10 after
388 .createLayoutObject(); 388 .createLayoutObject();
389 CharacterData::attachLayoutTree(reattachContext); 389 CharacterData::attachLayoutTree(reattachContext);
390 } 390 }
391 391
392 void Text::recalcTextStyle(StyleRecalcChange change, Text* nextTextSibling) { 392 void Text::recalcTextStyle(StyleRecalcChange change, Text* nextTextSibling) {
393 if (LayoutTextItem layoutItem = LayoutTextItem(this->layoutObject())) { 393 if (LayoutTextItem layoutItem = LayoutTextItem(this->layoutObject())) {
394 if (change != NoChange || needsStyleRecalc()) 394 if (change != NoChange || needsStyleRecalc())
395 layoutItem.setStyle(document().ensureStyleResolver().styleForText(this)); 395 layoutItem.setStyle(document().ensureStyleResolver().styleForText(this));
396 if (needsStyleRecalc()) 396 if (needsStyleRecalc())
397 layoutItem.setText(dataImpl()); 397 layoutItem.setText(dataImpl());
398 clearNeedsStyleRecalc();
399 } else if (needsStyleRecalc() || needsWhitespaceLayoutObject()) { 398 } else if (needsStyleRecalc() || needsWhitespaceLayoutObject()) {
400 rebuildTextLayoutTree(nextTextSibling); 399 setNeedsReattachLayoutTree();
401 } 400 }
401 clearNeedsStyleRecalc();
402 } 402 }
403 403
404 void Text::rebuildTextLayoutTree(Text* nextTextSibling) { 404 void Text::rebuildTextLayoutTree() {
nainar 2016/11/03 00:17:10 If bugs finishes his patch before this needs to la
405 DCHECK(!needsStyleRecalc());
406 DCHECK(!childNeedsStyleRecalc());
407 DCHECK(needsReattachLayoutTree());
408
405 reattachLayoutTree(); 409 reattachLayoutTree();
406 if (layoutObject()) 410 if (layoutObject()) {
407 reattachWhitespaceSiblingsIfNeeded(nextTextSibling); 411 // TODO(bugsnash): This is a performance regression - bugsnash is working on
412 // alleviating this regression
413 reattachWhitespaceSiblingsIfNeeded(nextTextSibling());
414 }
408 clearNeedsReattachLayoutTree(); 415 clearNeedsReattachLayoutTree();
409 } 416 }
410 417
411 // If a whitespace node had no layoutObject and goes through a recalcStyle it 418 // If a whitespace node had no layoutObject and goes through a recalcStyle it
412 // may need to create one if the parent style now has white-space: pre. 419 // may need to create one if the parent style now has white-space: pre.
413 bool Text::needsWhitespaceLayoutObject() { 420 bool Text::needsWhitespaceLayoutObject() {
414 DCHECK(!layoutObject()); 421 DCHECK(!layoutObject());
415 if (const ComputedStyle* style = parentComputedStyle()) 422 if (const ComputedStyle* style = parentComputedStyle())
416 return style->preserveNewline(); 423 return style->preserveNewline();
417 return false; 424 return false;
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
450 457
451 Text* Text::cloneWithData(const String& data) { 458 Text* Text::cloneWithData(const String& data) {
452 return create(document(), data); 459 return create(document(), data);
453 } 460 }
454 461
455 DEFINE_TRACE(Text) { 462 DEFINE_TRACE(Text) {
456 CharacterData::trace(visitor); 463 CharacterData::trace(visitor);
457 } 464 }
458 465
459 } // namespace blink 466 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698