Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1018)

Side by Side Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 2473743003: Call Element::rebuildLayoutTree from Document::updateStyle directly (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All
7 * rights reserved. 7 * rights reserved.
8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. 8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved.
9 * (http://www.torchmobile.com/) 9 * (http://www.torchmobile.com/)
10 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved. 10 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
(...skipping 1946 matching lines...) Expand 10 before | Expand all | Expand 10 after
1957 TRACE_EVENT_CATEGORY_GROUP_ENABLED("blink,blink_style", &shouldRecordStats); 1957 TRACE_EVENT_CATEGORY_GROUP_ENABLED("blink,blink_style", &shouldRecordStats);
1958 styleEngine().setStatsEnabled(shouldRecordStats); 1958 styleEngine().setStatsEnabled(shouldRecordStats);
1959 1959
1960 if (Element* documentElement = this->documentElement()) { 1960 if (Element* documentElement = this->documentElement()) {
1961 inheritHtmlAndBodyElementStyles(change); 1961 inheritHtmlAndBodyElementStyles(change);
1962 dirtyElementsForLayerUpdate(); 1962 dirtyElementsForLayerUpdate();
1963 if (documentElement->shouldCallRecalcStyle(change)) 1963 if (documentElement->shouldCallRecalcStyle(change))
1964 documentElement->recalcStyle(change); 1964 documentElement->recalcStyle(change);
1965 while (dirtyElementsForLayerUpdate()) 1965 while (dirtyElementsForLayerUpdate())
1966 documentElement->recalcStyle(NoChange); 1966 documentElement->recalcStyle(NoChange);
1967 DCHECK(!documentElement->needsStyleRecalc());
1968 DCHECK(!documentElement->childNeedsStyleRecalc());
1969 if (documentElement->needsReattachLayoutTree() ||
1970 documentElement->childNeedsReattachLayoutTree())
1971 documentElement->rebuildLayoutTree();
1967 } 1972 }
1968 1973
1969 view()->recalcOverflowAfterStyleChange(); 1974 view()->recalcOverflowAfterStyleChange();
1970 1975
1971 // Only retain the HashMap for the duration of StyleRecalc and 1976 // Only retain the HashMap for the duration of StyleRecalc and
1972 // LayoutTreeConstruction. 1977 // LayoutTreeConstruction.
1973 m_nonAttachedStyle.clear(); 1978 m_nonAttachedStyle.clear();
1974 clearChildNeedsStyleRecalc(); 1979 clearChildNeedsStyleRecalc();
1975 clearChildNeedsReattachLayoutTree(); 1980 clearChildNeedsReattachLayoutTree();
1976 1981
(...skipping 4487 matching lines...) Expand 10 before | Expand all | Expand 10 after
6464 } 6469 }
6465 6470
6466 void showLiveDocumentInstances() { 6471 void showLiveDocumentInstances() {
6467 WeakDocumentSet& set = liveDocumentSet(); 6472 WeakDocumentSet& set = liveDocumentSet();
6468 fprintf(stderr, "There are %u documents currently alive:\n", set.size()); 6473 fprintf(stderr, "There are %u documents currently alive:\n", set.size());
6469 for (Document* document : set) 6474 for (Document* document : set)
6470 fprintf(stderr, "- Document %p URL: %s\n", document, 6475 fprintf(stderr, "- Document %p URL: %s\n", document,
6471 document->url().getString().utf8().data()); 6476 document->url().getString().utf8().data());
6472 } 6477 }
6473 #endif 6478 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698